Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: device/devices_app/usb/device_manager_impl_unittest.cc

Issue 1345793002: Use complete USB DeviceInfo Mojo object to make permission decisions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manager_full_remove
Patch Set: Rebased. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/devices_app/usb/device_manager_impl_unittest.cc
diff --git a/device/devices_app/usb/device_manager_impl_unittest.cc b/device/devices_app/usb/device_manager_impl_unittest.cc
index 4f8984ae1baeba28bf54d40462906310b978ae96..88b1f97fa33e2152f1d03d8198a3ca3aa089429a 100644
--- a/device/devices_app/usb/device_manager_impl_unittest.cc
+++ b/device/devices_app/usb/device_manager_impl_unittest.cc
@@ -35,10 +35,13 @@ class TestPermissionProvider : public PermissionProvider {
~TestPermissionProvider() override {}
void HasDevicePermission(
- mojo::Array<mojo::String> requested_guids,
+ mojo::Array<DeviceInfoPtr> requested_devices,
const HasDevicePermissionCallback& callback) override {
// Permission to access all devices granted.
- callback.Run(requested_guids.Pass());
+ mojo::Array<mojo::String> allowed_guids(requested_devices.size());
+ for (size_t i = 0; i < requested_devices.size(); ++i)
+ allowed_guids[i] = requested_devices[i]->guid;
+ callback.Run(allowed_guids.Pass());
}
private:
« no previous file with comments | « device/devices_app/usb/device_manager_impl.cc ('k') | device/devices_app/usb/public/interfaces/permission_provider.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698