service/datastore/serialize/serialize_test.go - Issue 1345043005: Fix zero time bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: service/datastore/serialize/serialize_test.go

Issue 1345043005: Fix zero time bug (Closed) Base URL: https://github.com/luci/gae.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: service/datastore/serialize/serialize_test.go

diff --git a/service/datastore/serialize/serialize_test.go b/service/datastore/serialize/serialize_test.go

index d7e3f3f42158db126addab19c8107d80fa852395..2faae8ba9805611f664aafa1e72b2175648b149a 100644

--- a/service/datastore/serialize/serialize_test.go

+++ b/service/datastore/serialize/serialize_test.go

@@ -190,7 +190,7 @@ func TestSerializationReadMisc(t *testing.T) {

So(WriteTime(buf, time.Time{}), ShouldBeNil)

t, err := ReadTime(mkBuf(buf.Bytes()))

So(err, ShouldBeNil)

- So(t.IsZero(), ShouldBeTrue)

+ So(t, ShouldResemble, time.Time{})

})

Convey("Bad ToBytes", func() {

« no previous file with comments | « service/datastore/serialize/serialize.go ('k') | no next file » | no next file with comments »