Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 1345043002: Update access info when an offline page is being visited (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
index 1c698fce661f2ecd44419a27aa2042d89fd85f75..55718ffeb151f0395e37d5480eb33930bb45d74d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
@@ -48,6 +48,19 @@ public final class OfflinePageBridge {
}
/**
+ * Callback used to marking an offline page accessed.
+ */
+ public interface MarkPageAccessedCallback {
+ /**
+ * Delivers result of marking a page accessed.
+ *
+ * @param success Whether the operation succeeds.
+ */
+ @CalledByNative("MarkPageAccessedCallback")
+ void onMarkPageAccessedDone(boolean success);
+ }
+
+ /**
* Callback used to deleting an offline page.
*/
public interface DeletePageCallback {
@@ -161,6 +174,19 @@ public final class OfflinePageBridge {
}
/**
+ * Marks that an offline page related to a specified bookmark has been accessed.
+ *
+ * @param bookmarkId Bookmark ID for which the offline copy will be deleted.
+ * @param callback Interface that contains a callback.
+ * @see MarkPageAccessedCallback
+ */
+ @VisibleForTesting
+ public void markPageAccessed(BookmarkId bookmarkId, MarkPageAccessedCallback callback) {
Ian Wen 2015/09/18 21:20:44 How about add another public method called "markPa
jianli 2015/09/18 21:42:28 Done.
+ assert mIsNativeOfflinePageModelLoaded;
+ nativeMarkPageAccessed(mNativeOfflinePageBridge, callback, bookmarkId.getId());
+ }
+
+ /**
* Deletes an offline page related to a specified bookmark.
*
* @param bookmarkId Bookmark ID for which the offline copy will be deleted.
@@ -217,14 +243,15 @@ public final class OfflinePageBridge {
@CalledByNative
private static void createOfflinePageAndAddToList(List<OfflinePageItem> offlinePagesList,
- String url, long bookmarkId, String offlineUrl, long fileSize) {
- offlinePagesList.add(createOfflinePageItem(url, bookmarkId, offlineUrl, fileSize));
+ String url, long bookmarkId, String offlineUrl, long fileSize, int accessCount) {
+ offlinePagesList.add(createOfflinePageItem(url, bookmarkId, offlineUrl, fileSize,
+ accessCount));
}
@CalledByNative
private static OfflinePageItem createOfflinePageItem(
- String url, long bookmarkId, String offlineUrl, long fileSize) {
- return new OfflinePageItem(url, bookmarkId, offlineUrl, fileSize);
+ String url, long bookmarkId, String offlineUrl, long fileSize, int accessCount) {
+ return new OfflinePageItem(url, bookmarkId, offlineUrl, fileSize, accessCount);
}
private static native boolean nativeIsOfflinePagesEnabled();
@@ -237,6 +264,8 @@ public final class OfflinePageBridge {
long nativeOfflinePageBridge, long bookmarkId);
private native void nativeSavePage(long nativeOfflinePageBridge, SavePageCallback callback,
WebContents webContents, long bookmarkId);
+ private native void nativeMarkPageAccessed(long nativeOfflinePageBridge,
+ MarkPageAccessedCallback callback, long bookmarkId);
private native void nativeDeletePage(long nativeOfflinePageBridge,
DeletePageCallback callback, long bookmarkId);
private native void nativeDeletePages(

Powered by Google App Engine
This is Rietveld 408576698