Update access info when an offline page is being visited

chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.offlinepages;
 
 import org.chromium.base.ObserverList;
 import org.chromium.base.ThreadUtils;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.base.annotations.CalledByNative;
@@ skipping 30 matching lines @@
          * @param savePageResult Result of the saving. Uses
          *     {@see org.chromium.components.offlinepages.SavePageResult} enum.
          * @param url URL of the saved page.
          * @see OfflinePageBridge#savePage()
          */
         @CalledByNative("SavePageCallback")
         void onSavePageDone(int savePageResult, String url);
     }
 
     /**
+     * Callback used to marking an offline page accessed.
+     */
+    public interface MarkPageAccessedCallback {
+        /**
+         * Delivers result of marking a page accessed.
+         *
+         * @param success Whether the operation succeeds.
+         */
+        @CalledByNative("MarkPageAccessedCallback")
+        void onMarkPageAccessedDone(boolean success);
+    }
+
+    /**
      * Callback used to deleting an offline page.
      */
     public interface DeletePageCallback {
         /**
          * Delivers result of deleting a page.
          *
          * @param deletePageResult Result of deleting the page. Uses
          *     {@see org.chromium.components.offlinepages.DeletePageResult} enum.
          * @see OfflinePageBridge#deletePage()
          */
@@ skipping 93 matching lines @@
      * @see SavePageCallback
      */
     @VisibleForTesting
     public void savePage(
             WebContents webContents, BookmarkId bookmarkId, SavePageCallback callback) {
         assert mIsNativeOfflinePageModelLoaded;
         nativeSavePage(mNativeOfflinePageBridge, callback, webContents, bookmarkId.getId());
     }
 
     /**
+     * Marks that an offline page related to a specified bookmark has been accessed.
+     *
+     * @param bookmarkId Bookmark ID for which the offline copy will be deleted.
+     * @param callback Interface that contains a callback.
+     * @see MarkPageAccessedCallback
+     */
+    @VisibleForTesting
+    public void markPageAccessed(BookmarkId bookmarkId, MarkPageAccessedCallback callback) {

[Ian Wen, 2015/09/18 21:20:44]

How about add another public method called "markPageAccessedForTest(BookmarkId,
MarkPageAccessedCallback)", and change this method to not have the callback
parameter?

[jianli, 2015/09/18 21:42:28]

Done.

+        assert mIsNativeOfflinePageModelLoaded;
+        nativeMarkPageAccessed(mNativeOfflinePageBridge, callback, bookmarkId.getId());
+    }
+
+    /**
      * Deletes an offline page related to a specified bookmark.
      *
      * @param bookmarkId Bookmark ID for which the offline copy will be deleted.
      * @param callback Interface that contains a callback.
      * @see DeletePageCallback
      */
     @VisibleForTesting
     public void deletePage(BookmarkId bookmarkId, DeletePageCallback callback) {
         assert mIsNativeOfflinePageModelLoaded;
         nativeDeletePage(mNativeOfflinePageBridge, callback, bookmarkId.getId());
@@ skipping 36 matching lines @@
     @CalledByNative
     private void offlinePageModelLoaded() {
         mIsNativeOfflinePageModelLoaded = true;
         for (OfflinePageModelObserver observer : mObservers) {
             observer.offlinePageModelLoaded();
         }
     }
 
     @CalledByNative
     private static void createOfflinePageAndAddToList(List<OfflinePageItem> offlinePagesList,
-            String url, long bookmarkId, String offlineUrl, long fileSize) {
-        offlinePagesList.add(createOfflinePageItem(url, bookmarkId, offlineUrl, fileSize));
+            String url, long bookmarkId, String offlineUrl, long fileSize, int accessCount) {
+        offlinePagesList.add(createOfflinePageItem(url, bookmarkId, offlineUrl, fileSize,
+                accessCount));
     }
 
     @CalledByNative
     private static OfflinePageItem createOfflinePageItem(
-            String url, long bookmarkId, String offlineUrl, long fileSize) {
-        return new OfflinePageItem(url, bookmarkId, offlineUrl, fileSize);
+            String url, long bookmarkId, String offlineUrl, long fileSize, int accessCount) {
+        return new OfflinePageItem(url, bookmarkId, offlineUrl, fileSize, accessCount);
     }
 
     private static native boolean nativeIsOfflinePagesEnabled();
 
     private native long nativeInit(Profile profile);
     private native void nativeDestroy(long nativeOfflinePageBridge);
     private native void nativeGetAllPages(
             long nativeOfflinePageBridge, List<OfflinePageItem> offlinePages);
     private native OfflinePageItem nativeGetPageByBookmarkId(
             long nativeOfflinePageBridge, long bookmarkId);
     private native void nativeSavePage(long nativeOfflinePageBridge, SavePageCallback callback,
             WebContents webContents, long bookmarkId);
+    private native void nativeMarkPageAccessed(long nativeOfflinePageBridge,
+            MarkPageAccessedCallback callback, long bookmarkId);
     private native void nativeDeletePage(long nativeOfflinePageBridge,
             DeletePageCallback callback, long bookmarkId);
     private native void nativeDeletePages(
             long nativeOfflinePageBridge, DeletePageCallback callback, long[] bookmarkIds);
     private native void nativeGetPagesToCleanUp(
             long nativeOfflinePageBridge, List<OfflinePageItem> offlinePages);
 }