Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java

Issue 1345043002: Update access info when an offline page is being visited (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
index 3f258249d716a1bfca0f19141ccbb319b454ded5..204ff78ec1b46ccdd880e76456292fb51a719eda 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
@@ -238,7 +238,15 @@ public class EnhancedBookmarksModel extends BookmarksBridge {
// Return the offline url for the offline page.
OfflinePageItem page = mOfflinePageBridge.getPageByBookmarkId(bookmarkId);
- return page == null ? url : page.getOfflineUrl();
+ if (page == null) {
Ian Wen 2015/09/18 21:20:44 Inline the return.
jianli 2015/09/18 21:42:28 Done.
+ return url;
+ }
+
+ // Mark that the offline page has been accessed, that will cause last access time and access
+ // count being updated.
+ mOfflinePageBridge.markPageAccessed(bookmarkId, null);
+
+ return page.getOfflineUrl();
}
/**

Powered by Google App Engine
This is Rietveld 408576698