Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 134453004: Use a bitfield to store animatable properties. (Closed)

Created:
6 years, 11 months ago by Ian Vollick
Modified:
6 years, 11 months ago
Reviewers:
girard, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, sadrul, tfarina, sievers+watch_chromium.org, jbauman+watch_chromium.org, ben+corewm_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, ben+ash_chromium.org, bshe
Visibility:
Public.

Description

Use a bitfield to store animatable properties. This makes much more sense than a std::set (which is what we're currently doing). R=sky@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244643

Patch Set 1 #

Patch Set 2 : Updated the unittests #

Patch Set 3 : fix win build error #

Total comments: 6

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : fix another win build error (signed/unsigned comp). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -220 lines) Patch
M ash/rotator/screen_rotation.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/rotator/screen_rotation.cc View 2 chunks +1 line, -10 lines 0 comments Download
M ash/shelf/app_list_button.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ash/wm/overview/window_selector_panels.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ash/wm/window_animations.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace_controller.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M ui/app_list/views/pulsing_block_view.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M ui/compositor/layer_animation_element.h View 1 2 3 4 chunks +16 lines, -11 lines 0 comments Download
M ui/compositor/layer_animation_element.cc View 25 chunks +16 lines, -83 lines 0 comments Download
M ui/compositor/layer_animation_element_unittest.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M ui/compositor/layer_animation_observer.cc View 1 chunk +9 lines, -4 lines 0 comments Download
M ui/compositor/layer_animation_sequence.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/compositor/layer_animation_sequence.cc View 1 2 4 chunks +9 lines, -14 lines 0 comments Download
M ui/compositor/layer_animation_sequence_unittest.cc View 1 2 3 4 5 5 chunks +17 lines, -21 lines 0 comments Download
M ui/compositor/layer_animator.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/compositor/layer_animator.cc View 7 chunks +18 lines, -30 lines 0 comments Download
M ui/compositor/layer_animator_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/compositor/scoped_layer_animation_settings.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M ui/compositor/test/layer_animator_test_controller.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/corewm/window_animations.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Ian Vollick
6 years, 11 months ago (2014-01-10 20:52:46 UTC) #1
girard
Nice cleanup Ian.
6 years, 11 months ago (2014-01-10 20:57:42 UTC) #2
Ian Vollick
On 2014/01/10 20:57:42, girard wrote: > Nice cleanup Ian. Oof. Looks like I missed updating ...
6 years, 11 months ago (2014-01-10 21:05:49 UTC) #3
Ian Vollick
On 2014/01/10 21:05:49, Ian Vollick wrote: > On 2014/01/10 20:57:42, girard wrote: > > Nice ...
6 years, 11 months ago (2014-01-11 02:18:15 UTC) #4
sky
Nice, LGTM https://codereview.chromium.org/134453004/diff/160001/ui/compositor/layer_animation_element.h File ui/compositor/layer_animation_element.h (right): https://codereview.chromium.org/134453004/diff/160001/ui/compositor/layer_animation_element.h#newcode62 ui/compositor/layer_animation_element.h:62: typedef unsigned AnimatableProperties; I believe we generally ...
6 years, 11 months ago (2014-01-13 14:26:42 UTC) #5
Ian Vollick
https://codereview.chromium.org/134453004/diff/160001/ui/compositor/layer_animation_element.h File ui/compositor/layer_animation_element.h (right): https://codereview.chromium.org/134453004/diff/160001/ui/compositor/layer_animation_element.h#newcode62 ui/compositor/layer_animation_element.h:62: typedef unsigned AnimatableProperties; On 2014/01/13 14:26:42, sky wrote: > ...
6 years, 11 months ago (2014-01-13 19:03:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/134453004/290001
6 years, 11 months ago (2014-01-13 19:18:44 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=245572
6 years, 11 months ago (2014-01-13 19:58:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/134453004/470002
6 years, 11 months ago (2014-01-13 21:31:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/134453004/470002
6 years, 11 months ago (2014-01-14 00:05:35 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-14 03:10:26 UTC) #11
Message was sent while issue was closed. 
Change committed as 244643

Powered by Google App Engine
This is Rietveld 408576698