Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1343123005: use SkBitmapProvider for shader-context (Closed)

Created:
5 years, 3 months ago by reed1
Modified:
5 years, 3 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

use SkBitmapProvider for shader-context BUG=skia: Committed: https://skia.googlesource.com/skia/+/7a4d84755801db35a4d5fc231278089b228e8c57

Patch Set 1 #

Patch Set 2 : restore privacy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -34 lines) Patch
M include/core/SkShader.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkBitmapController.h View 1 chunk +6 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 5 chunks +11 lines, -5 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 2 chunks +19 lines, -13 lines 0 comments Download
M src/core/SkBitmapProcState.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 2 chunks +18 lines, -2 lines 0 comments Download
M src/core/SkLightingShader.cpp View 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
reed1
ptal
5 years, 3 months ago (2015-09-15 20:17:15 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343123005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343123005/1
5 years, 3 months ago (2015-09-15 20:17:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 20:23:31 UTC) #6
f(malita)
LGTM w/ friend SkBitmapProcShader.
5 years, 3 months ago (2015-09-15 20:27:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343123005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343123005/20001
5 years, 3 months ago (2015-09-15 20:28:06 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 20:34:01 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7a4d84755801db35a4d5fc231278089b228e8c57

Powered by Google App Engine
This is Rietveld 408576698