.gn - Issue 1342293002: Move `gn check` into the `generate_build_files` step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: .gn

Issue 1342293002: Move `gn check` into the `generate_build_files` step. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: back out installer changes, do not check //chrome/installer Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: .gn

diff --git a/.gn b/.gn

index 62b55b28b7892a15e877c544a0f62227ad27931f..a9552c749eaf55f3891807c5f925ed0eb3a1f802 100644

--- a/.gn

+++ b/.gn

@@ -24,7 +24,7 @@ check_targets = [

"//cc/*",

#"//chrome/*", # Epic number of errors.

- "//chrome/installer/*",

+ #"//chrome/installer/*", # A few errors, need to verify the size after fixing.

"//chromecast/*",

# TODO(brettw): Fix http://crbug.com/460828 and uncomment the following

@@ -38,7 +38,10 @@ check_targets = [

"//components/bookmarks/*",

"//components/google/*",

"//components/history/*",

- "//components/html_viewer/*",

+ # TODO(dpranke): Reenable once v8 exports v8_base as a public_dep

+ #"//components/html_viewer/*",

"//components/mus/*",

"//components/omnibox/*",

"//components/os_crypt/*",

« no previous file with comments | « no previous file | components/html_viewer/BUILD.gn » ('j') | no next file with comments »