tools/mb/mb.py - Issue 1342293002: Move `gn check` into the `generate_build_files` step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/mb/mb.py

Issue 1342293002: Move `gn check` into the `generate_build_files` step. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: back out installer changes, do not check //chrome/installer Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/mb/mb.py

diff --git a/tools/mb/mb.py b/tools/mb/mb.py

index b4f7e770dbbc65154bc3f5095fe7b5151000625c..a55542d844e9d61b29980b12c2b9b395ad65f83f 100755

--- a/tools/mb/mb.py

+++ b/tools/mb/mb.py

@@ -354,7 +354,7 @@ class MetaBuildWrapper(object):

def RunGNGen(self, vals):

path = self.args.path[0]

- cmd = self.GNCmd('gen', path, vals['gn_args'])

+ cmd = self.GNCmd('gen', path, vals['gn_args'], extra_args=['--check'])

swarming_targets = []

if self.args.swarming_targets_file:

@@ -438,7 +438,7 @@ class MetaBuildWrapper(object):

return ret

- def GNCmd(self, subcommand, path, gn_args=''):

+ def GNCmd(self, subcommand, path, gn_args='', extra_args=None):

if self.platform == 'linux2':

gn_path = os.path.join(self.chromium_src_dir, 'buildtools', 'linux64',

'gn')

@@ -453,6 +453,8 @@ class MetaBuildWrapper(object):

gn_args = gn_args.replace("$(goma_dir)", self.args.goma_dir)

if gn_args:

cmd.append('--args=%s' % gn_args)

+ if extra_args:

+ cmd.extend(extra_args)

return cmd

def RunGYPGen(self, vals):

« no previous file with comments | « testing/buildbot/tryserver.v8.json ('k') | no next file » | no next file with comments »