Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1341853002: Test that GrFragmentProcessors work without input colors. (Closed)

Created:
5 years, 3 months ago by bsalomon
Modified:
5 years, 3 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : Update more FPs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -19 lines) Patch
M include/gpu/GrProcessorUnitTest.h View 1 1 chunk +10 lines, -1 line 0 comments Download
M src/gpu/effects/GrConstColorProcessor.cpp View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M src/gpu/effects/GrExtractAlphaFragmentProcessor.cpp View 1 chunk +7 lines, -3 lines 0 comments Download
M src/gpu/effects/GrXfermodeFragmentProcessor.cpp View 3 chunks +16 lines, -9 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 6 chunks +85 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
bsalomon
5 years, 3 months ago (2015-09-14 16:26:10 UTC) #2
joshualitt
On 2015/09/14 16:26:10, bsalomon wrote: lgtm, but the lack of name mangling in GrComposeShader could ...
5 years, 3 months ago (2015-09-14 17:50:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341853002/20001
5 years, 3 months ago (2015-09-14 18:49:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/72c58e7052af2a0855412ce4b249f977069db751
5 years, 3 months ago (2015-09-14 18:55:55 UTC) #6
bsalomon
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1338403003/ by bsalomon@google.com. ...
5 years, 3 months ago (2015-09-14 19:01:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341853002/40001
5 years, 3 months ago (2015-09-14 19:20:18 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 19:26:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b5b603241aaa99e07dc4e12ca9f2661aa85e5f74

Powered by Google App Engine
This is Rietveld 408576698