Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1334273003: Add helper for creating leaf FPs inside GrFP::TestCreate functions (Closed)

Created:
5 years, 3 months ago by bsalomon
Modified:
5 years, 3 months ago
Reviewers:
joshualitt, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@noinputtest
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add helper for creating leaf FPs inside GrFP::TestCreate functions Committed: https://skia.googlesource.com/skia/+/506c802a3dd3b6dc8a172621ff2a1f9bda202a13

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : rename #

Patch Set 5 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -22 lines) Patch
M gyp/gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrProcessorUnitTest.h View 1 2 3 4 3 chunks +7 lines, -4 lines 0 comments Download
M include/gpu/effects/GrExtractAlphaFragmentProcessor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A src/gpu/GrProcessorUnitTest.cpp View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
M src/gpu/effects/GrExtractAlphaFragmentProcessor.cpp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/effects/GrXfermodeFragmentProcessor.cpp View 1 2 3 1 chunk +2 lines, -17 lines 0 comments Download

Depends on Patchset:

Issue 1341853002 Patch 40001

Dependent Patchsets:

Issue 1334293003 Patch 40001

Messages

Total messages: 10 (4 generated)
bsalomon
5 years, 3 months ago (2015-09-14 17:51:35 UTC) #2
bsalomon
As I'm expanding the set of FPs that have children it seemed like we should ...
5 years, 3 months ago (2015-09-14 19:37:23 UTC) #4
egdaniel
lgtm https://codereview.chromium.org/1334273003/diff/40001/include/gpu/GrProcessorUnitTest.h File include/gpu/GrProcessorUnitTest.h (right): https://codereview.chromium.org/1334273003/diff/40001/include/gpu/GrProcessorUnitTest.h#newcode28 include/gpu/GrProcessorUnitTest.h:28: /** This allows parent FPs to implement a ...
5 years, 3 months ago (2015-09-14 20:00:26 UTC) #5
bsalomon
https://codereview.chromium.org/1334273003/diff/40001/include/gpu/GrProcessorUnitTest.h File include/gpu/GrProcessorUnitTest.h (right): https://codereview.chromium.org/1334273003/diff/40001/include/gpu/GrProcessorUnitTest.h#newcode28 include/gpu/GrProcessorUnitTest.h:28: /** This allows parent FPs to implement a test ...
5 years, 3 months ago (2015-09-14 20:05:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334273003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334273003/80001
5 years, 3 months ago (2015-09-14 20:05:45 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 20:16:28 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/506c802a3dd3b6dc8a172621ff2a1f9bda202a13

Powered by Google App Engine
This is Rietveld 408576698