Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Issue 134153016: add 'manipulation' support to CSS touch-action parsing. (Closed)

Created:
6 years, 11 months ago by gnana
Modified:
6 years, 9 months ago
Reviewers:
Rick Byers, eseidel
CC:
blink-reviews, jamesr, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

add 'manipulation' support to CSS touch-action parsing. 'manipulation' is added in latest editors draft https://dvcs.w3.org/hg/pointerevents/raw-file/tip/pointerEvents.html#the-touch-action-css-property BUG=349016 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168752

Patch Set 1 : #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : incorporated review comments #

Patch Set 4 : rebase to trunk #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -10 lines) Patch
M LayoutTests/fast/css/touch-action-parsing.html View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/touch-action-parsing-expected.txt View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 1 chunk +8 lines, -5 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 2 3 1 chunk +1 line, -0 lines 1 comment Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/tests/TouchActionTest.cpp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/tests/data/touch-action-pan.html View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M Source/web/tests/data/touch-action-tests.css View 1 2 chunks +8 lines, -0 lines 0 comments Download
M public/web/WebTouchAction.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
gnana
Please have a look.
6 years, 11 months ago (2014-01-24 16:17:07 UTC) #1
Rick Byers
I'd love to be able to do this! But unfortunately it's unlikely to meet the ...
6 years, 11 months ago (2014-01-24 17:03:26 UTC) #2
gnana
On 2014/01/24 17:03:26, Rick Byers wrote: > I'd love to be able to do this! ...
6 years, 11 months ago (2014-01-24 18:04:45 UTC) #3
Rick Byers
On 2014/01/24 18:04:45, gnana wrote: > On 2014/01/24 17:03:26, Rick Byers wrote: > > I'd ...
6 years, 9 months ago (2014-03-04 16:31:31 UTC) #4
gnana
On 2014/03/04 16:31:31, Rick Byers wrote: > On 2014/01/24 18:04:45, gnana wrote: > > On ...
6 years, 9 months ago (2014-03-04 16:34:18 UTC) #5
Rick Byers
On 2014/03/04 16:34:18, gnana wrote: > On 2014/03/04 16:31:31, Rick Byers wrote: > > On ...
6 years, 9 months ago (2014-03-04 17:58:59 UTC) #6
gnana
Please have a look.
6 years, 9 months ago (2014-03-05 10:32:03 UTC) #7
Rick Byers
Looks good, thank you! Just a couple small suggestions. https://codereview.chromium.org/134153016/diff/90001/LayoutTests/fast/css/touch-action-parsing.html File LayoutTests/fast/css/touch-action-parsing.html (right): https://codereview.chromium.org/134153016/diff/90001/LayoutTests/fast/css/touch-action-parsing.html#newcode24 LayoutTests/fast/css/touch-action-parsing.html:24: ...
6 years, 9 months ago (2014-03-05 14:41:12 UTC) #8
gnana
Thanks rick, Please have a look. https://codereview.chromium.org/134153016/diff/90001/LayoutTests/fast/css/touch-action-parsing.html File LayoutTests/fast/css/touch-action-parsing.html (right): https://codereview.chromium.org/134153016/diff/90001/LayoutTests/fast/css/touch-action-parsing.html#newcode24 LayoutTests/fast/css/touch-action-parsing.html:24: <div class="test" id="explicit-manipulation" ...
6 years, 9 months ago (2014-03-06 08:11:14 UTC) #9
Rick Byers
LGTM, thanks for the quick turn-around! I'm hoping we can ship touch action next week ...
6 years, 9 months ago (2014-03-06 14:12:59 UTC) #10
eseidel
Is this CSS Property guarded behind a runtime flag? Should it be? https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/css/RuntimeCSSEnabled.cpp&q=RuntimeEnabled&sq=package:chromium&l=33
6 years, 9 months ago (2014-03-07 21:05:39 UTC) #11
Rick Byers
On 2014/03/07 21:05:39, eseidel wrote: > Is this CSS Property guarded behind a runtime flag? ...
6 years, 9 months ago (2014-03-07 21:29:50 UTC) #12
eseidel
lgtm https://codereview.chromium.org/134153016/diff/150001/Source/core/css/CSSValueKeywords.in File Source/core/css/CSSValueKeywords.in (right): https://codereview.chromium.org/134153016/diff/150001/Source/core/css/CSSValueKeywords.in#newcode1012 Source/core/css/CSSValueKeywords.in:1012: manipulation I see now, this is adding a ...
6 years, 9 months ago (2014-03-07 21:34:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/134153016/150001
6 years, 9 months ago (2014-03-07 21:35:12 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 22:01:11 UTC) #15
Message was sent while issue was closed.
Change committed as 168752

Powered by Google App Engine
This is Rietveld 408576698