Chromium Code Reviews Chromium Code Reviews
Issue 134153016:
add 'manipulation' support to CSS touch-action parsing. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE HTML> | 1 <!DOCTYPE HTML> |
| 2 <html> | 2 <html> |
| 3 <head> | 3 <head> |
| 4 <script src="../../resources/js-test.js"></script> | 4 <script src="../../resources/js-test.js"></script> |
| 5 <style> | 5 <style> |
| 6 /* | 6 /* |
| 7 Give some rules below something to override in order to test | 7 Give some rules below something to override in order to test |
| 8 that they really are being parsed | 8 that they really are being parsed |
| 9 */ | 9 */ |
| 10 .defnone { | 10 .defnone { |
| 11 touch-action: none; | 11 touch-action: none; |
| 12 } | 12 } |
| 13 </style> | 13 </style> |
| 14 </head> | 14 </head> |
| 15 <body> | 15 <body> |
| 16 <p id="description"></p> | 16 <p id="description"></p> |
| 17 <div class="test" id="default" expected="auto"></div> | 17 <div class="test" id="default" expected="auto"></div> |
| 18 <div class="test defnone" id="stylesheet-none" expected="none"></div> | 18 <div class="test defnone" id="stylesheet-none" expected="none"></div> |
| 19 <div class="test defnone" id="explicit-auto" style="touch-action: auto;" expecte d="auto"></div> | 19 <div class="test defnone" id="explicit-auto" style="touch-action: auto;" expecte d="auto"></div> |
| 20 <div class="test" id="explicit-pan-x" style="touch-action: pan-x;" expected="pan -x"></div> | 20 <div class="test" id="explicit-pan-x" style="touch-action: pan-x;" expected="pan -x"></div> |
| 21 <div class="test" id="explicit-pan-y" style="touch-action: pan-y;" expected="pan -y"></div> | 21 <div class="test" id="explicit-pan-y" style="touch-action: pan-y;" expected="pan -y"></div> |
| 22 <div class="test" id="explicit-pan-x-pan-y" style="touch-action: pan-x pan-y;" e xpected="pan-x pan-y"></div> | 22 <div class="test" id="explicit-pan-x-pan-y" style="touch-action: pan-x pan-y;" e xpected="pan-x pan-y"></div> |
| 23 <div class="test" id="explicit-pan-y-pan-x" style="touch-action: pan-y pan-x;" e xpected="pan-x pan-y"></div> | 23 <div class="test" id="explicit-pan-y-pan-x" style="touch-action: pan-y pan-x;" e xpected="pan-x pan-y"></div> |
| 24 <div class="test" id="explicit-manipulation" style="touch-action: manipulation;" expected="manipulation"></div> | |
|
Rick Byers
2014/03/05 14:41:13
please add a test that verifies a combination like
gnana
2014/03/06 08:11:14
Done.
| |
| 24 <div class="test" id="explicit-none" style="touch-action: none;" expected="none" ></div> | 25 <div class="test" id="explicit-none" style="touch-action: none;" expected="none" ></div> |
| 25 <div class="test" id="explicit-invalid-1" style="touch-action: bogus;" expected= "auto"></div> | 26 <div class="test" id="explicit-invalid-1" style="touch-action: bogus;" expected= "auto"></div> |
| 26 <div class="test defnone" id="explicit-invalid-2" style="touch-action: auto pan- x;" expected="none"></div> | 27 <div class="test defnone" id="explicit-invalid-2" style="touch-action: auto pan- x;" expected="none"></div> |
| 27 <div class="test" id="explicit-invalid-3" style="touch-action: pan-y none;" expe cted="auto"></div> | 28 <div class="test" id="explicit-invalid-3" style="touch-action: pan-y none;" expe cted="auto"></div> |
| 28 <div class="test" id="explicit-invalid-4" style="touch-action: pan-x pan-x;" exp ected="auto"></div> | 29 <div class="test" id="explicit-invalid-4" style="touch-action: pan-x pan-x;" exp ected="auto"></div> |
| 29 <div style="touch-action: none;"> | 30 <div style="touch-action: none;"> |
| 30 <div class="test" id="not-inherited" expected="auto"></div> | 31 <div class="test" id="not-inherited" expected="auto"></div> |
| 31 <div class="test" id="inherit" style="touch-action: inherit;" expected="none"> </div> | 32 <div class="test" id="inherit" style="touch-action: inherit;" expected="none"> </div> |
| 32 </div> | 33 </div> |
| 33 <div class="test defnone" id="initial" style="touch-action: initial;" expected=" auto"></div> | 34 <div class="test defnone" id="initial" style="touch-action: initial;" expected=" auto"></div> |
| 34 | 35 |
| 35 <div id="console"></div> | 36 <div id="console"></div> |
| 36 <script> | 37 <script> |
| 37 description("Test the parsing and application of the touch-action property."); | 38 description("Test the parsing and application of the touch-action property."); |
| 38 | 39 |
| 39 var tests = document.querySelectorAll('.test'); | 40 var tests = document.querySelectorAll('.test'); |
| 40 var style; | 41 var style; |
| 41 for (var i = 0; i < tests.length; i++) { | 42 for (var i = 0; i < tests.length; i++) { |
| 42 debug('Test case: ' + tests[i].id); | 43 debug('Test case: ' + tests[i].id); |
| 43 style = window.getComputedStyle(tests[i]); | 44 style = window.getComputedStyle(tests[i]); |
| 44 shouldBeEqualToString('style.touchAction', tests[i].attributes.expected.value) ; | 45 shouldBeEqualToString('style.touchAction', tests[i].attributes.expected.value) ; |
| 45 debug(''); | 46 debug(''); |
| 46 } | 47 } |
| 47 | 48 |
| 48 successfullyParsed = true; | 49 successfullyParsed = true; |
| 49 </script> | 50 </script> |
| 50 </body> | 51 </body> |
| 51 </html> | 52 </html> |
| OLD | NEW |
