Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1341013002: [Android] Move weak ref for PopupWindowTouchHandleDrawable to native (Closed)

Created:
5 years, 3 months ago by jdduke (slow)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Move weak ref for PopupWindowTouchHandleDrawable to native The current weak reference wiring for PopupWindowTouchHandleDrawable is awkward and fragile. Move the weak ref accounting to its native object counterpart, using the JNI boundary as a consistent reference lifetime checkpoint. BUG=528365 Committed: https://crrev.com/7a60160df059c5031f1d6d040b2779061dc20d9c Cr-Commit-Position: refs/heads/master@{#348809}

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Final cleanup #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -154 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M content/browser/android/popup_touch_handle_drawable.h View 1 2 2 chunks +9 lines, -3 lines 0 comments Download
M content/browser/android/popup_touch_handle_drawable.cc View 1 2 1 chunk +50 lines, -20 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 7 chunks +12 lines, -38 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java View 1 2 3 12 chunks +46 lines, -78 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
jdduke (slow)
OK, here's patch #2 of the cleanup (one more coming... let me know if you ...
5 years, 3 months ago (2015-09-14 20:42:16 UTC) #2
aurimas (slooooooooow)
LGTM, this makes the life time of the Java object much easier to understand.
5 years, 3 months ago (2015-09-14 23:20:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341013002/40001
5 years, 3 months ago (2015-09-14 23:46:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/69118) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-14 23:49:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341013002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341013002/60001
5 years, 3 months ago (2015-09-15 00:14:18 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-15 01:32:49 UTC) #11
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/7a60160df059c5031f1d6d040b2779061dc20d9c Cr-Commit-Position: refs/heads/master@{#348809}
5 years, 3 months ago (2015-09-15 01:33:33 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:41:05 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7a60160df059c5031f1d6d040b2779061dc20d9c
Cr-Commit-Position: refs/heads/master@{#348809}

Powered by Google App Engine
This is Rietveld 408576698