content/browser/renderer_host/render_widget_host_view_android.cc - Issue 1341013002: [Android] Move weak ref for PopupWindowTouchHandleDrawable to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 1341013002: [Android] Move weak ref for PopupWindowTouchHandleDrawable to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/popup_touch_handle_drawable.cc ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 9e4370f867afbc3511c6933ca16788b7324235a7..5ebf4e68a7d5a8d18024ac0db0fd419502e1c5ba 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -40,6 +40,7 @@

#include "content/browser/android/edge_effect_l.h"

#include "content/browser/android/in_process/synchronous_compositor_impl.h"

#include "content/browser/android/overscroll_controller_android.h"

+#include "content/browser/android/popup_touch_handle_drawable.h"

#include "content/browser/devtools/render_frame_devtools_agent_host.h"

#include "content/browser/gpu/browser_gpu_channel_host_factory.h"

#include "content/browser/gpu/compositor_util.h"

@@ -1246,7 +1247,7 @@ scoped_ptr<ui::TouchHandleDrawable>

RenderWidgetHostViewAndroid::CreateDrawable() {

DCHECK(content_view_core_);

if (!using_browser_compositor_)

- return content_view_core_->CreatePopupTouchHandleDrawable();

+ return PopupTouchHandleDrawable::Create(content_view_core_);

return scoped_ptr<ui::TouchHandleDrawable>(new CompositedTouchHandleDrawable(

content_view_core_->GetLayer().get(),