Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 1341013002: [Android] Move weak ref for PopupWindowTouchHandleDrawable to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 12696c730fbcc2469125cafba532550aefbd622c..623052332a8ab4e1bf62f5c577169bf6d028527c 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -70,8 +70,6 @@ import org.chromium.content.browser.input.JoystickScrollProvider;
import org.chromium.content.browser.input.LegacyPastePopupMenu;
import org.chromium.content.browser.input.PastePopupMenu;
import org.chromium.content.browser.input.PastePopupMenu.PastePopupMenuDelegate;
-import org.chromium.content.browser.input.PopupTouchHandleDrawable;
-import org.chromium.content.browser.input.PopupTouchHandleDrawable.PopupTouchHandleDrawableDelegate;
import org.chromium.content.browser.input.SelectPopup;
import org.chromium.content.browser.input.SelectPopupDialog;
import org.chromium.content.browser.input.SelectPopupDropdown;
@@ -498,10 +496,6 @@ public class ContentViewCore implements
private PastePopupMenu mPastePopupMenu;
private boolean mWasPastePopupShowingOnInsertionDragStart;
- private PopupTouchHandleDrawableDelegate mTouchHandleDelegate;
-
- private PositionObserver mPositionObserver;
-
// Size of the viewport in physical pixels as set from onSizeChanged.
private int mViewportWidthPix;
private int mViewportHeightPix;
@@ -900,7 +894,6 @@ public class ContentViewCore implements
}
mContainerView = containerView;
- mPositionObserver = new ViewPositionObserver(mContainerView);
mContainerView.setClickable(true);
mViewAndroidDelegate.updateCurrentContainerView(mContainerView);
for (ContainerViewObserver observer : mContainerViewObservers) {
@@ -1031,7 +1024,6 @@ public class ContentViewCore implements
unregisterAccessibilityContentObserver();
mGestureStateListeners.clear();
ScreenOrientationListener.getInstance().removeObserver(this);
- mPositionObserver.clearListener();
mContainerViewObservers.clear();
hidePopupsAndPreserveSelection();
mPastePopupMenu = null;
@@ -1200,6 +1192,15 @@ public class ContentViewCore implements
return onTouchEventImpl(event, isTouchHandleEvent);
}
+ /**
+ * Called by PopupWindow-based touch handles.
+ * @param event the MotionEvent targeting the handle.
+ */
+ public boolean onTouchHandleEvent(MotionEvent event) {
+ final boolean isTouchHandleEvent = true;
+ return onTouchEventImpl(event, isTouchHandleEvent);
+ }
+
private boolean onTouchEventImpl(MotionEvent event, boolean isTouchHandleEvent) {
TraceEvent.begin("onTouchEvent");
try {
@@ -1265,6 +1266,9 @@ public class ContentViewCore implements
|| eventAction == MotionEvent.ACTION_POINTER_UP;
}
+ /**
+ * @return Whether a scroll targeting web content is in progress.
+ */
public boolean isScrollInProgress() {
return mTouchScrollInProgress || mPotentiallyActiveFlingCount > 0;
}
@@ -2570,36 +2574,6 @@ public class ContentViewCore implements
return new MotionEventSynthesizer(this);
}
- @SuppressWarnings("unused")
- @CalledByNative
- private PopupTouchHandleDrawable createPopupTouchHandleDrawable() {
- if (mTouchHandleDelegate == null) {
- mTouchHandleDelegate = new PopupTouchHandleDrawableDelegate() {
- @Override
- public View getParent() {
- return getContainerView();
- }
-
- @Override
- public PositionObserver getParentPositionObserver() {
- return mPositionObserver;
- }
-
- @Override
- public boolean onTouchHandleEvent(MotionEvent event) {
- final boolean isTouchHandleEvent = true;
- return onTouchEventImpl(event, isTouchHandleEvent);
- }
-
- @Override
- public boolean isScrollInProgress() {
- return ContentViewCore.this.isScrollInProgress();
- }
- };
- }
- return new PopupTouchHandleDrawable(mTouchHandleDelegate);
- }
-
/**
* Initialize the view with an overscroll refresh handler.
* @param handler The refresh handler.

Powered by Google App Engine
This is Rietveld 408576698