Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1340413004: Cleanup: Pass std::string as const reference from extensions/ (Closed)

Created:
5 years, 3 months ago by ki.stfu
Modified:
5 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Pass std::string as const reference from extensions/ Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=reillyg@chromium.org,asargent@chromium.org Committed: https://crrev.com/4fc405185a586d3caaa51ea0d1e74ce2d8eb3b0b Cr-Commit-Position: refs/heads/master@{#349905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -31 lines) Patch
M extensions/browser/api/declarative/rules_registry_service.h View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/browser/api/networking_config/networking_config_service.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/networking_config/networking_config_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_renderer_state.h View 1 chunk +2 lines, -3 lines 0 comments Download
M extensions/common/manifest_test.h View 1 chunk +9 lines, -6 lines 0 comments Download
M extensions/common/manifest_test.cc View 1 chunk +14 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
ki.stfu
5 years, 3 months ago (2015-09-20 20:09:24 UTC) #1
Reilly Grant (use Gerrit)
lgtm
5 years, 3 months ago (2015-09-21 06:08:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340413004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340413004/1
5 years, 3 months ago (2015-09-21 06:17:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 06:55:09 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4fc405185a586d3caaa51ea0d1e74ce2d8eb3b0b Cr-Commit-Position: refs/heads/master@{#349905}
5 years, 3 months ago (2015-09-21 06:55:49 UTC) #6
asargent_no_longer_on_chrome
Hi ki.stfu - thanks for contributing this patch. FYI, you should only add one reviewer ...
5 years, 3 months ago (2015-09-21 18:20:28 UTC) #7
ki.stfu
5 years, 3 months ago (2015-09-21 21:18:52 UTC) #8
Message was sent while issue was closed.
On 2015/09/21 18:20:28, Antony Sargent wrote:
> Hi ki.stfu - thanks for contributing this patch. FYI, you should only add one
> reviewer to your codereview where possible, and if you need to add multiple
> reviewers because some files are covered by different OWNERS files you should
> explicitly state in the initial publish email who should review what. E.g. if
> you needed reviews from both mailto:abcd@chromium.org and
mailto:efgh@chromium.org, you'd
> write something like:
> 
> abcd: please review changed files in foo/bar/baz/
> efgh: please review some/file.cc
> 
> In the case of this patch reillyg and I are both in the extensions/OWNERS
file,
> so you only needed to add one of us. No problem; just try and remember this
> guideline for the future. Thanks again for contributing!

@asargent: OK, thanks for clarifying!

Powered by Google App Engine
This is Rietveld 408576698