extensions/browser/api/declarative/rules_registry_service.h - Issue 1340413004: Cleanup: Pass std::string as const reference from extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative/rules_registry_service.h

Issue 1340413004: Cleanup: Pass std::string as const reference from extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/declarative/rules_registry_service.h

diff --git a/extensions/browser/api/declarative/rules_registry_service.h b/extensions/browser/api/declarative/rules_registry_service.h

index 8f16cb2a530ea7778fce779fe6049da72e6ebc24..c00ce5749c4d2f37213dc0fa5950736d802229ea 100644

--- a/extensions/browser/api/declarative/rules_registry_service.h

+++ b/extensions/browser/api/declarative/rules_registry_service.h

@@ -40,9 +40,8 @@ class RulesRegistryService : public BrowserContextKeyedAPI,

struct RulesRegistryKey {

std::string event_name;

int rules_registry_id;

- RulesRegistryKey(const std::string event_name, int rules_registry_id)

- : event_name(event_name),

- rules_registry_id(rules_registry_id) {}

+ RulesRegistryKey(const std::string& event_name, int rules_registry_id)

+ : event_name(event_name), rules_registry_id(rules_registry_id) {}

bool operator<(const RulesRegistryKey& other) const {

return (event_name < other.event_name) ||

((event_name == other.event_name) &&

« no previous file with comments | « no previous file | extensions/browser/api/networking_config/networking_config_service.h » ('j') | no next file with comments »