extensions/browser/api/networking_config/networking_config_service.cc - Issue 1340413004: Cleanup: Pass std::string as const reference from extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_config/networking_config_service.cc

Issue 1340413004: Cleanup: Pass std::string as const reference from extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/networking_config/networking_config_service.h ('k') | extensions/browser/guest_view/web_view/web_view_renderer_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_config/networking_config_service.cc

diff --git a/extensions/browser/api/networking_config/networking_config_service.cc b/extensions/browser/api/networking_config/networking_config_service.cc

index b9b4233890da220194709972de274472aa713bac..faec72d6f19277528162bf89eda4cff74bafe527 100644

--- a/extensions/browser/api/networking_config/networking_config_service.cc

+++ b/extensions/browser/api/networking_config/networking_config_service.cc

@@ -78,7 +78,7 @@ std::string NetworkingConfigService::LookupExtensionIdForHexSsid(

}

bool NetworkingConfigService::IsRegisteredForCaptivePortalEvent(

- std::string extension_id) const {

+ const std::string& extension_id) const {

return event_delegate_->HasExtensionRegisteredForEvent(extension_id);

}