Issue 133983002: Update XML classes to use OVERRIDE / FINAL when needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133983002: Update XML classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
abarth-chromium, esprehn, eseidel

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Update XML classes to use OVERRIDE / FINAL when needed Update XML classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=esprehn, abarth BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164903

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+142 lines, -142 lines)			Patch
M	Source/core/xml/DocumentXPathEvaluator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/NativeXPathNSResolver.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/XMLHttpRequest.h	View	3 chunks	+13 lines, -13 lines	0 comments	Download
M	Source/core/xml/XMLHttpRequestProgressEvent.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/xml/XMLHttpRequestProgressEventThrottle.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/xml/XMLHttpRequestUpload.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/XPathFunctions.cpp	View	1 chunk	+81 lines, -81 lines	0 comments	Download
M	Source/core/xml/XPathPredicate.h	View	1 chunk	+21 lines, -21 lines	0 comments	Download
M	Source/core/xml/XPathStep.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/xml/XPathVariableReference.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/xml/XSLImportRule.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/xml/XSLStyleSheet.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/parser/XMLDocumentParser.h	View	4 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/133983002/1

6 years, 11 months ago (2014-01-10 20:41:39 UTC) #3

Message was sent while issue was closed.

Change committed as 164903

Expand Messages | Collapse Messages