Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: Source/core/xml/XMLHttpRequest.h

Issue 133983002: Update XML classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/xml/NativeXPathNSResolver.h ('k') | Source/core/xml/XMLHttpRequestProgressEvent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/XMLHttpRequest.h
diff --git a/Source/core/xml/XMLHttpRequest.h b/Source/core/xml/XMLHttpRequest.h
index 00bde33130ba2244674ebf8236153ff21fd4e11d..6cd13dc0f5f4985c47ec79d02e8e37a176e920a6 100644
--- a/Source/core/xml/XMLHttpRequest.h
+++ b/Source/core/xml/XMLHttpRequest.h
@@ -53,12 +53,12 @@ class ThreadableLoader;
typedef int ExceptionCode;
-class XMLHttpRequest : public ScriptWrappable, public RefCounted<XMLHttpRequest>, public XMLHttpRequestEventTarget, private ThreadableLoaderClient, public ActiveDOMObject {
+class XMLHttpRequest FINAL : public ScriptWrappable, public RefCounted<XMLHttpRequest>, public XMLHttpRequestEventTarget, private ThreadableLoaderClient, public ActiveDOMObject {
WTF_MAKE_FAST_ALLOCATED;
REFCOUNTED_EVENT_TARGET(XMLHttpRequest);
public:
static PassRefPtr<XMLHttpRequest> create(ExecutionContext*, PassRefPtr<SecurityOrigin> = 0);
- ~XMLHttpRequest();
+ virtual ~XMLHttpRequest();
// These exact numeric values are important because JS expects them.
enum State {
@@ -84,10 +84,10 @@ public:
DropProtectionAsync,
};
- virtual void contextDestroyed();
- virtual void suspend();
- virtual void resume();
- virtual void stop();
+ virtual void contextDestroyed() OVERRIDE;
+ virtual void suspend() OVERRIDE;
+ virtual void resume() OVERRIDE;
+ virtual void stop() OVERRIDE;
virtual const AtomicString& interfaceName() const OVERRIDE;
virtual ExecutionContext* executionContext() const OVERRIDE;
@@ -149,15 +149,15 @@ private:
Document* document() const;
SecurityOrigin* securityOrigin() const;
- virtual void didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent);
- virtual void didReceiveResponse(unsigned long identifier, const ResourceResponse&);
- virtual void didReceiveData(const char* data, int dataLength);
+ virtual void didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent) OVERRIDE;
+ virtual void didReceiveResponse(unsigned long identifier, const ResourceResponse&) OVERRIDE;
+ virtual void didReceiveData(const char* data, int dataLength) OVERRIDE;
// When "blob" is specified as the responseType attribute, didDownloadData
// is called instead of didReceiveData.
- virtual void didDownloadData(int dataLength);
- virtual void didFinishLoading(unsigned long identifier, double finishTime);
- virtual void didFail(const ResourceError&);
- virtual void didFailRedirectCheck();
+ virtual void didDownloadData(int dataLength) OVERRIDE;
+ virtual void didFinishLoading(unsigned long identifier, double finishTime) OVERRIDE;
+ virtual void didFail(const ResourceError&) OVERRIDE;
+ virtual void didFailRedirectCheck() OVERRIDE;
AtomicString responseMIMEType() const;
bool responseIsXML() const;
« no previous file with comments | « Source/core/xml/NativeXPathNSResolver.h ('k') | Source/core/xml/XMLHttpRequestProgressEvent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698