Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Unified Diff: Source/core/xml/parser/XMLDocumentParser.h

Issue 133983002: Update XML classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/xml/XSLStyleSheet.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/parser/XMLDocumentParser.h
diff --git a/Source/core/xml/parser/XMLDocumentParser.h b/Source/core/xml/parser/XMLDocumentParser.h
index 2db50a0b7e2ecd551b386feea933c53b6255739e..294c02d8cceea9b4a32603c05d1176b055df5002 100644
--- a/Source/core/xml/parser/XMLDocumentParser.h
+++ b/Source/core/xml/parser/XMLDocumentParser.h
@@ -63,7 +63,7 @@ class Text;
xmlParserCtxtPtr m_context;
};
- class XMLDocumentParser : public ScriptableDocumentParser, public ResourceClient {
+ class XMLDocumentParser FINAL : public ScriptableDocumentParser, public ResourceClient {
WTF_MAKE_FAST_ALLOCATED;
public:
static PassRefPtr<XMLDocumentParser> create(Document* document, FrameView* view)
@@ -75,7 +75,7 @@ class Text;
return adoptRef(new XMLDocumentParser(fragment, element, parserContentPolicy));
}
- ~XMLDocumentParser();
+ virtual ~XMLDocumentParser();
// Exposed for callbacks:
void handleError(XMLErrors::ErrorType, const char* message, TextPosition);
@@ -88,9 +88,9 @@ class Text;
static bool parseDocumentFragment(const String&, DocumentFragment*, Element* parent = 0, ParserContentPolicy = AllowScriptingContent);
// Used by the XMLHttpRequest to check if the responseXML was well formed.
- virtual bool wellFormed() const { return !m_sawError; }
+ virtual bool wellFormed() const OVERRIDE { return !m_sawError; }
- TextPosition textPosition() const;
+ virtual TextPosition textPosition() const OVERRIDE;
static bool supportsXMLVersion(const String&);
@@ -105,17 +105,17 @@ class Text;
XMLDocumentParser(DocumentFragment*, Element*, ParserContentPolicy);
// From DocumentParser
- virtual void insert(const SegmentedString&);
- virtual void append(PassRefPtr<StringImpl>);
- virtual void finish();
- virtual bool isWaitingForScripts() const;
- virtual void stopParsing();
- virtual void detach();
- virtual OrdinalNumber lineNumber() const;
+ virtual void insert(const SegmentedString&) OVERRIDE;
+ virtual void append(PassRefPtr<StringImpl>) OVERRIDE;
+ virtual void finish() OVERRIDE;
+ virtual bool isWaitingForScripts() const OVERRIDE;
+ virtual void stopParsing() OVERRIDE;
+ virtual void detach() OVERRIDE;
+ virtual OrdinalNumber lineNumber() const OVERRIDE;
OrdinalNumber columnNumber() const;
// from ResourceClient
- virtual void notifyFinished(Resource*);
+ virtual void notifyFinished(Resource*) OVERRIDE;
void end();
« no previous file with comments | « Source/core/xml/XSLStyleSheet.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698