win: Fix ProcessInfo test when running on x86 host OS

win: Fix ProcessInfo test when running on x86 host OS

R=mark@chromium.org
BUG=crashpad:50
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/6c23e37ee9a702167930a2eb8debaf87457eff3f

[Mark Mentovai, 2015-09-11 22:38:57]

https://codereview.chromium.org/1339813002/diff/1/util/win/process_info_test.cc
File util/win/process_info_test.cc (right):

https://codereview.chromium.org/1339813002/diff/1/util/win/process_info_test....
util/win/process_info_test.cc:56: char* processor_architew6432 =
getenv("PROCESSOR_ARCHITEW6432");
I think that using environment variables like this is a little hokey, because
they’re so easy to change and mess up. I’d suggest
IsWow64Process(GetCurrentProcess()), but then I guess you’d just be testing the
same thing that ProcessInfo does. But maybe that’s not so terrible, since it’s
basically up to the system to get this right.

https://codereview.chromium.org/1339813002/diff/1/util/win/process_info_test....
util/win/process_info_test.cc:57: if (processor_architew6432 &&
std::string(processor_architew6432) == "AMD64")
Just strcmp() instead of creating a std::string?

[scottmg, 2015-09-11 23:39:55]

https://codereview.chromium.org/1339813002/diff/1/util/win/process_info_test.cc
File util/win/process_info_test.cc (right):

https://codereview.chromium.org/1339813002/diff/1/util/win/process_info_test....
util/win/process_info_test.cc:56: char* processor_architew6432 =
getenv("PROCESSOR_ARCHITEW6432");
On 2015/09/11 22:38:56, Mark Mentovai - August is over wrote:
> I think that using environment variables like this is a little hokey, because
> they’re so easy to change and mess up. I’d suggest
> IsWow64Process(GetCurrentProcess()), but then I guess you’d just be testing
the
> same thing that ProcessInfo does. But maybe that’s not so terrible, since it’s
> basically up to the system to get this right.

Yeah, that's I tried to verify with "some other" source of data. Maybe it's just
as sensible to delete the EXPECT_ then, rather than duplicate the exact same
code as on the other side?

[Mark Mentovai, 2015-09-12 00:26:14]

I guess there’s still value because we might find some super-snazzy
internals-using way to determine WoW64-ness based on some other struct we’ve
already read, and get rid of the IsWow64Process() call from process_reader.

However you’d like to handle this is fine, even if you really do want to keep
the environment read, since it’s just a test.

[scottmg, 2015-09-14 17:51:03]

OK, switch to IsWow64Process.

[Mark Mentovai, 2015-09-14 17:58:38]

LGTM

[scottmg, 2015-09-14 18:08:02]

Committed patchset #2 (id:20001) manually as
6c23e37ee9a702167930a2eb8debaf87457eff3f (presubmit successful).