win: Fix ProcessInfo test when running on x86 host OS

util/win/process_info_test.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/win/process_info.h"
 
 #include <imagehlp.h>
 #include <rpc.h>
+#include <stdlib.h>
 #include <wchar.h>
 
 #include "base/files/file_path.h"
 #include "build/build_config.h"
 #include "gtest/gtest.h"
 #include "test/paths.h"
 #include "util/file/file_io.h"
 #include "util/misc/uuid.h"
 #include "util/win/scoped_handle.h"
 
@@ skipping 16 matching lines @@
   ProcessInfo process_info;
   ASSERT_TRUE(process_info.Initialize(GetCurrentProcess()));
   EXPECT_EQ(GetCurrentProcessId(), process_info.ProcessID());
   EXPECT_GT(process_info.ParentProcessID(), 0u);
 
 #if defined(ARCH_CPU_64_BITS)
   EXPECT_TRUE(process_info.Is64Bit());
   EXPECT_FALSE(process_info.IsWow64());
 #else
   EXPECT_FALSE(process_info.Is64Bit());
-  // Assume we won't be running these tests on a 32 bit host OS.
-  EXPECT_TRUE(process_info.IsWow64());
+  char* processor_architew6432 = getenv("PROCESSOR_ARCHITEW6432");

[Mark Mentovai, 2015/09/11 22:38:56]

I think that using environment variables like this is a little hokey, because
they’re so easy to change and mess up. I’d suggest
IsWow64Process(GetCurrentProcess()), but then I guess you’d just be testing the
same thing that ProcessInfo does. But maybe that’s not so terrible, since it’s
basically up to the system to get this right.

[scottmg, 2015/09/11 23:39:55]

Yeah, that's I tried to verify with "some other" source of data. Maybe it's just
as sensible to delete the EXPECT_ then, rather than duplicate the exact same
code as on the other side?

+  if (processor_architew6432 && std::string(processor_architew6432) == "AMD64")

[Mark Mentovai, 2015/09/11 22:38:56]

Just strcmp() instead of creating a std::string?

+    EXPECT_TRUE(process_info.IsWow64());
+  else
+    EXPECT_FALSE(process_info.IsWow64());
 #endif
 
   std::wstring command_line;
   EXPECT_TRUE(process_info.CommandLine(&command_line));
   EXPECT_EQ(std::wstring(GetCommandLine()), command_line);
 
   std::vector<ProcessInfo::Module> modules;
   EXPECT_TRUE(process_info.Modules(&modules));
   ASSERT_GE(modules.size(), 2u);
   const wchar_t kSelfName[] = L"\\crashpad_util_test.exe";
@@ skipping 94 matching lines @@
   TestOtherProcess(L"x64");
 }
 
 TEST(ProcessInfo, OtherProcessX86) {
   TestOtherProcess(L"x86");
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad