win: Fix pipe leak on connection

win: Fix pipe leak on connection

The pipe handle was being leaked on connections (oops!). On XP this
resulted in the next test's CreateNamedPipe to fail, because the
previous one still existed (because all handles were not closed). More
recent OSs are more forgiving so I got away with the buggy code.

R=mark@chromium.org
BUG=crashpad:50
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/81269ee676d8aa5f7e5e7f3a142de6718293de6d

[Mark Mentovai, 2015-09-11 22:29:00]

Wow, good catch. Thanks, XP!

https://codereview.chromium.org/1337953003/diff/1/util/win/exception_handler_...
File util/win/exception_handler_server.cc (right):

https://codereview.chromium.org/1337953003/diff/1/util/win/exception_handler_...
util/win/exception_handler_server.cc:227: CreateThread(nullptr, 0,
&PipeServiceProc, context, 0, nullptr));
PCHECK for CreateThread() too?

[Mark Mentovai, 2015-09-11 22:29:09]

P.S. That means LGTM.

[scottmg, 2015-09-11 22:33:52]

https://codereview.chromium.org/1337953003/diff/1/util/win/exception_handler_...
File util/win/exception_handler_server.cc (right):

https://codereview.chromium.org/1337953003/diff/1/util/win/exception_handler_...
util/win/exception_handler_server.cc:227: CreateThread(nullptr, 0,
&PipeServiceProc, context, 0, nullptr));
On 2015/09/11 22:29:00, Mark Mentovai - August is over wrote:
> PCHECK for CreateThread() too?

Done.

[scottmg, 2015-09-11 22:34:40]

Committed patchset #2 (id:20001) manually as
81269ee676d8aa5f7e5e7f3a142de6718293de6d (presubmit successful).