Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: build/android/pylib/device/commands/install_commands.py

Issue 1339683002: DeviceUtils: Fix crash when creating error message for a non-userdebugdevice (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/device/commands/install_commands.py
diff --git a/build/android/pylib/device/commands/install_commands.py b/build/android/pylib/device/commands/install_commands.py
index f7319a2a21cac8c47b0820393cead1691fed5075..fde606f12dc365193b89d2ebcce130c01d7a69e0 100644
--- a/build/android/pylib/device/commands/install_commands.py
+++ b/build/android/pylib/device/commands/install_commands.py
@@ -33,7 +33,7 @@ def InstallCommands(device):
if device.IsUserBuild():
raise device_errors.CommandFailedError(
'chromium_commands currently requires a userdebug build.',
- device_serial=device.GetDeviceSerial())
+ device_serial=device.adb.GetDeviceSerial())
jbudorick 2015/09/11 15:34:34 uh... er... how did this get here
chromium_commands_jar_path = os.path.join(
constants.GetOutDirectory(), constants.SDK_BUILD_JAVALIB_DIR,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698