Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1339123002: Remove some usage of testRunner.setPermission. (Closed)

Created:
5 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 3 months ago
Reviewers:
johnme, whywhat
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@notifications-flakyness
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove some usage of testRunner.setPermission. This is removing all the mentions of testRunner.setPermission outside of LayoutTests/http/tests/. BUG=None Committed: https://crrev.com/7454d2ab79c525a289d21f0a0fd40ddbaa63ff3c git-svn-id: svn://svn.chromium.org/blink/trunk@202356 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -16 lines) Patch
M LayoutTests/inspector/geolocation-emulation-tests.html View 2 chunks +13 lines, -3 lines 0 comments Download
M LayoutTests/inspector/geolocation-emulation-tests-expected.txt View 1 1 chunk +7 lines, -4 lines 0 comments Download
M LayoutTests/webmidi/loopback-receive.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/webmidi/loopback-receive-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webmidi/permission.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webmidi/permission-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webmidi/send-messages.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webmidi/send-messages-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
mlamouri (slow - plz ping)
5 years, 3 months ago (2015-09-14 17:52:46 UTC) #2
mlamouri (slow - plz ping)
5 years, 3 months ago (2015-09-16 14:54:04 UTC) #4
whywhat
lgtm https://codereview.chromium.org/1339123002/diff/1/LayoutTests/resources/permissions-helper.js File LayoutTests/resources/permissions-helper.js (right): https://codereview.chromium.org/1339123002/diff/1/LayoutTests/resources/permissions-helper.js#newcode45 LayoutTests/resources/permissions-helper.js:45: testRunner.setPermission(name, state, location.origin, location.origin); you haven't really removed ...
5 years, 3 months ago (2015-09-16 15:03:09 UTC) #5
whywhat
https://codereview.chromium.org/1339123002/diff/1/LayoutTests/inspector/geolocation-emulation-tests.html File LayoutTests/inspector/geolocation-emulation-tests.html (right): https://codereview.chromium.org/1339123002/diff/1/LayoutTests/inspector/geolocation-emulation-tests.html#newcode7 LayoutTests/inspector/geolocation-emulation-tests.html:7: function grantGeolocationPermission() { you also need to update the ...
5 years, 3 months ago (2015-09-16 15:05:22 UTC) #6
mlamouri (slow - plz ping)
comments applied.
5 years, 3 months ago (2015-09-16 16:04:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339123002/20001
5 years, 3 months ago (2015-09-16 16:04:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202356
5 years, 3 months ago (2015-09-16 16:46:06 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:56:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7454d2ab79c525a289d21f0a0fd40ddbaa63ff3c

Powered by Google App Engine
This is Rietveld 408576698