LayoutTests/inspector/geolocation-emulation-tests.html - Issue 1339123002: Remove some usage of testRunner.setPermission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/geolocation-emulation-tests.html

Issue 1339123002: Remove some usage of testRunner.setPermission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@notifications-flakyness

Patch Set: review comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/inspector/geolocation-emulation-tests.html

diff --git a/LayoutTests/inspector/geolocation-emulation-tests.html b/LayoutTests/inspector/geolocation-emulation-tests.html

index 778862c11b4b214b0478dcf8f7ee86eef447142c..08f9455c9d20c25cca205d92cd143d0d85dd3e15 100644

--- a/LayoutTests/inspector/geolocation-emulation-tests.html

+++ b/LayoutTests/inspector/geolocation-emulation-tests.html

@@ -1,8 +1,15 @@

<html>

<head>

+<script src="../resources/permissions-helper.js"></script>

+function grantGeolocationPermission() {

+ PermissionsHelper.setPermission('geolocation', 'granted').then(function(p) {

+ console.log("Permission granted.");

+ });

function serializeGeolocationError(error) {

var result = "Unknown error"

switch (error.code)

@@ -60,10 +67,13 @@ function overridenTimestampGeolocation()

function test()

{

- if (window.testRunner)

- window.testRunner.setPermission('geolocation', 'granted', location.origin, location.origin);

InspectorTest.runTestSuite([

+ function testPermissionGranted(next)

+ {

+ InspectorTest.addConsoleSniffer(next);

+ InspectorTest.evaluateInPage("grantGeolocationPermission()");

+ },

function testGeolocationUnavailable(next)

{

InspectorTest.EmulationAgent.setGeolocationOverride();

« no previous file with comments | « no previous file | LayoutTests/inspector/geolocation-emulation-tests-expected.txt » ('j') | no next file with comments »