Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1346213002: Permission TestRunner: only use permissions-helper.js from http/tests/. (Closed)

Created:
5 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 3 months ago
Reviewers:
whywhat
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@testrunner-setpermission-removal
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Permission TestRunner: only use permissions-helper.js from http/tests/. This prevent having to duplicate permissions-helper.js. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -54 lines) Patch
M LayoutTests/inspector/geolocation-emulation-tests.html View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/resources/permissions-helper.js View 1 chunk +0 lines, -50 lines 0 comments Download
M LayoutTests/webmidi/loopback-receive.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webmidi/permission.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webmidi/send-messages.html View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1339123002 Patch 20001

Messages

Total messages: 6 (2 generated)
mlamouri (slow - plz ping)
5 years, 3 months ago (2015-09-16 16:06:41 UTC) #2
whywhat
lgtm
5 years, 3 months ago (2015-09-17 12:56:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346213002/1
5 years, 3 months ago (2015-09-17 12:56:31 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 13:00:41 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202447

Powered by Google App Engine
This is Rietveld 408576698