Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: components/autofill/content/browser/autofill_driver_impl.cc

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Allow Password autofill suggestions deletion Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/autofill_driver_impl.cc
diff --git a/components/autofill/content/browser/autofill_driver_impl.cc b/components/autofill/content/browser/autofill_driver_impl.cc
index 43e5d92a2d2fc1b0460409b34bda80943961acc7..2f9234581caae41dac9c167700e0a08c02bedb95 100644
--- a/components/autofill/content/browser/autofill_driver_impl.cc
+++ b/components/autofill/content/browser/autofill_driver_impl.cc
@@ -1,9 +1,7 @@
// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-
vabr (Chromium) 2014/01/29 16:09:36 Please return those two blank lines.
vabr (Chromium) 2014/02/05 20:34:20 I believe you forgot to address this.
#include "components/autofill/content/browser/autofill_driver_impl.h"
-
#include "base/command_line.h"
#include "base/threading/sequenced_worker_pool.h"
#include "components/autofill/core/browser/autofill_external_delegate.h"
@@ -131,6 +129,15 @@ void AutofillDriverImpl::SendAutofillTypePredictionsToRenderer(
type_predictions));
}
+void AutofillDriverImpl::RemovePasswordAutofillSuggestion(
+ const PasswordForm& password_form) {
+ if (!RendererIsAvailable())
+ return;
+ content::RenderViewHost* host = web_contents()->GetRenderViewHost();
+ host->Send(new AutofillMsg_RemovePasswordSuggestion(host->GetRoutingID(),
+ password_form));
+}
+
void AutofillDriverImpl::RendererShouldAcceptDataListSuggestion(
const base::string16& value) {
if (!RendererIsAvailable())
@@ -138,6 +145,7 @@ void AutofillDriverImpl::RendererShouldAcceptDataListSuggestion(
content::RenderViewHost* host = web_contents()->GetRenderViewHost();
host->Send(new AutofillMsg_AcceptDataListSuggestion(host->GetRoutingID(),
value));
+
vabr (Chromium) 2014/01/29 16:09:36 Please remove this blank line.
riadh.chtara 2014/02/04 16:22:03 Done.
}
void AutofillDriverImpl::RendererShouldAcceptPasswordAutofillSuggestion(

Powered by Google App Engine
This is Rietveld 408576698