Allow deleting autofill password suggestions on Shift+Delete

components/autofill/content/browser/autofill_driver_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-

[vabr (Chromium), 2014/01/29 16:09:36]

Please return those two blank lines.

[vabr (Chromium), 2014/02/05 20:34:20]

I believe you forgot to address this.

 #include "components/autofill/content/browser/autofill_driver_impl.h"
-
 #include "base/command_line.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "components/autofill/core/browser/autofill_external_delegate.h"
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "components/autofill/core/browser/autofill_manager_delegate.h"
 #include "components/autofill/core/common/autofill_messages.h"
 #include "components/autofill/core/browser/form_structure.h"
 #include "components/autofill/core/common/autofill_switches.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 107 matching lines @@
   if (!host)
     return;
 
   std::vector<FormDataPredictions> type_predictions;
   FormStructure::GetFieldTypePredictions(forms, &type_predictions);
   host->Send(
       new AutofillMsg_FieldTypePredictionsAvailable(host->GetRoutingID(),
                                                     type_predictions));
 }
 
+void AutofillDriverImpl::RemovePasswordAutofillSuggestion(
+    const PasswordForm& password_form) {
+  if (!RendererIsAvailable())
+    return;
+  content::RenderViewHost* host = web_contents()->GetRenderViewHost();
+  host->Send(new AutofillMsg_RemovePasswordSuggestion(host->GetRoutingID(),
+                                                      password_form));
+}
+
 void AutofillDriverImpl::RendererShouldAcceptDataListSuggestion(
     const base::string16& value) {
   if (!RendererIsAvailable())
     return;
   content::RenderViewHost* host = web_contents()->GetRenderViewHost();
   host->Send(new AutofillMsg_AcceptDataListSuggestion(host->GetRoutingID(),
                                                       value));
+

[vabr (Chromium), 2014/01/29 16:09:36]

Please remove this blank line.

[riadh.chtara, 2014/02/04 16:22:03]

Done.

 }
 
 void AutofillDriverImpl::RendererShouldAcceptPasswordAutofillSuggestion(
     const base::string16& username) {
   if (!RendererIsAvailable())
     return;
   content::RenderViewHost* host = web_contents()->GetRenderViewHost();
   host->Send(
       new AutofillMsg_AcceptPasswordAutofillSuggestion(host->GetRoutingID(),
                                                        username));
@@ skipping 83 matching lines @@
 void AutofillDriverImpl::NavigationEntryCommitted(
     const content::LoadCommittedDetails& load_details) {
   autofill_manager_->delegate()->HideAutofillPopup();
 }
 
 void AutofillDriverImpl::WasHidden() {
   autofill_manager_->delegate()->HideAutofillPopup();
 }
 
 }  // namespace autofill