Allow deleting autofill password suggestions on Shift+Delete

components/autofill/content/renderer/autofill_agent.cc

Index: components/autofill/content/renderer/autofill_agent.cc
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc
index 25b02c309cab953cdde940894c24a7c2f59a738c..b2f636bd07c94d181fc32f6eefa1aa83acd87db5 100644
--- a/components/autofill/content/renderer/autofill_agent.cc
+++ b/components/autofill/content/renderer/autofill_agent.cc
@@ -14,6 +14,7 @@
 #include "components/autofill/content/renderer/form_autofill_util.h"
 #include "components/autofill/content/renderer/page_click_tracker.h"
 #include "components/autofill/content/renderer/password_autofill_agent.h"
+#include "components/autofill/content/renderer/password_form_conversion_utils.h"
 #include "components/autofill/core/common/autofill_constants.h"
 #include "components/autofill/core/common/autofill_messages.h"
 #include "components/autofill/core/common/autofill_switches.h"
@@ -551,6 +552,9 @@ void AutofillAgent::QueryAutofillSuggestions(const WebInputElement& element,
     // at providing suggestions.
     WebFormControlElementToFormField(element, EXTRACT_VALUE, &field);
   }
+  scoped_ptr<PasswordForm> password_form(
+      CreatePasswordForm(element.form()));
+  DCHECK(password_form);

[vabr (Chromium), 2014/01/29 16:09:36]

Is QueryAutofillSuggestions also called for non-password web forms? In that
case, the code should handle password_form==NULL.

[riadh.chtara, 2014/02/04 16:22:03]

I'm going to remove it.

 
   gfx::RectF bounding_box_scaled =
       GetScaledBoundingBox(web_view_->pageScaleFactor(), &element_);
@@ -570,6 +574,7 @@ void AutofillAgent::QueryAutofillSuggestions(const WebInputElement& element,
                                                   autofill_query_id_,
                                                   form,
                                                   field,
+                                                  *password_form,
                                                   bounding_box_scaled,
                                                   display_warning_if_disabled));
 }