Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1338893002: Use gold for linking on both 32-bit and 64-bit linux GN builds. (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang, brettw
CC:
chromium-reviews, Nico, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@always_use_gold
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use gold for linking on both 32-bit and 64-bit linux GN builds. R=brettw@chromium.org, thestig@chromium.org BUG=432959 Committed: https://crrev.com/cc2490a2986d70a393c04b6f69e52e82514bc9b7 Cr-Commit-Position: refs/heads/master@{#348703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Dirk Pranke
In GYP these days it looks like we always use a 64-bit gold to do ...
5 years, 3 months ago (2015-09-11 21:58:21 UTC) #1
Lei Zhang
lgtm I think anyone building on a 32-bit kernel+userland Linux machine is just going to ...
5 years, 3 months ago (2015-09-11 22:01:48 UTC) #2
brettw
lgtm
5 years, 3 months ago (2015-09-12 00:03:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338893002/1
5 years, 3 months ago (2015-09-12 00:15:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/115223)
5 years, 3 months ago (2015-09-12 03:17:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338893002/1
5 years, 3 months ago (2015-09-14 19:22:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 20:18:53 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cc2490a2986d70a393c04b6f69e52e82514bc9b7 Cr-Commit-Position: refs/heads/master@{#348703}
5 years, 3 months ago (2015-09-14 20:19:40 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:36:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc2490a2986d70a393c04b6f69e52e82514bc9b7
Cr-Commit-Position: refs/heads/master@{#348703}

Powered by Google App Engine
This is Rietveld 408576698