Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: build/config/compiler/BUILD.gn

Issue 1338893002: Use gold for linking on both 32-bit and 64-bit linux GN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@always_use_gold
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 1a7df3025fa011bbc8e1c257f3169229c99594ae..329173197acbcb26f5313c67d229d1256c71d2ad 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -44,9 +44,9 @@ declare_args() {
# Requires profiling to be set to true.
enable_full_stack_frames_for_profiling = false
- # Use gold for linking on 64-bit Linux only (on 32-bit it runs out of
- # address space, and it doesn't support cross-compiling).
- use_gold = is_linux && current_cpu == "x64"
+ # Use 64-bit gold for linking on both 64-bit Linux and 32-bit linux;
+ # 32-bit Gold runs out of address-space on 32-bit bit builds.
+ use_gold = is_linux && (current_cpu == "x64" || current_cpu == "x86")
# When we are going to use gold we need to find it.
if (use_gold) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698