|
|
DescriptionAlways use the 64 bit linker on Linux 32 bit builds.
Recent changes (merging PDFium) have pushed some binaries over the limit.
BUG=453844
R=thestig@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/4e86d25e8bee33105970ed9b1b4eb0684fa955ed
Patch Set 1 #
Messages
Total messages: 17 (4 generated)
jam@chromium.org changed reviewers: + thestig@chromium.org
- Can you prepend "Linux: " to the commit message? - The bug number doesn't look right. Still building locally. I can push the commit button for you once I verify this CL.
On 2015/02/05 01:42:40, Lei Zhang wrote: > - Can you prepend "Linux: " to the commit message? this is a convention i'm not familiar with :) since it's not in the chromium dev workflow, i prefer not to add extra stuff. > - The bug number doesn't look right. ah, updated it to tie it to the bug that's tracking merging pdfium > > Still building locally. I can push the commit button for you once I verify this > CL.
On 2015/02/05 01:50:24, jam wrote: > On 2015/02/05 01:42:40, Lei Zhang wrote: > > - Can you prepend "Linux: " to the commit message? > > this is a convention i'm not familiar with :) since it's not in the chromium dev > workflow, i prefer not to add extra stuff. Well, if one just read the commit message, one has no idea if this affects Windows or Linux or all platforms.
On 2015/02/05 01:54:43, Lei Zhang wrote: > On 2015/02/05 01:50:24, jam wrote: > > On 2015/02/05 01:42:40, Lei Zhang wrote: > > > - Can you prepend "Linux: " to the commit message? > > > > this is a convention i'm not familiar with :) since it's not in the chromium > dev > > workflow, i prefer not to add extra stuff. > > Well, if one just read the commit message, one has no idea if this affects > Windows or Linux or all platforms. good point, updated desc
The CQ bit was checked by thestig@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897163002/1
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4e86d25e8bee33105970ed9b1b4eb0684fa955ed Cr-Commit-Position: refs/heads/master@{#314730}
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 4e86d25e8bee33105970ed9b1b4eb0684fa955ed (presubmit successful).
Message was sent while issue was closed.
thakis@chromium.org changed reviewers: + thakis@chromium.org
Message was sent while issue was closed.
fyi, I tried the same change (except I did it for gn too) in https://code.google.com/p/chromium/issues/detail?id=396333 and had to revert it 'cause it increased bss size or something – see the bug for details.
Message was sent while issue was closed.
dcheng@chromium.org changed reviewers: + dcheng@chromium.org
Message was sent while issue was closed.
Is there any chance this is causing errors like: Command: ../out/Debug/browser_tests --test-launcher-bot-mode --test-launcher-summary-output=/tmp/isolated_out2lpJpD/output.json ../out/Debug/browser_tests: error while loading shared libraries: libwtf.so: cannot open shared object file: No such file or directory See https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2... for an example failure.
Message was sent while issue was closed.
On 2015/02/05 08:17:56, dcheng wrote: > Is there any chance this is causing errors like: > > Command: ../out/Debug/browser_tests --test-launcher-bot-mode > --test-launcher-summary-output=/tmp/isolated_out2lpJpD/output.json > > ../out/Debug/browser_tests: error while loading shared libraries: libwtf.so: > cannot open shared object file: No such file or directory > > See > https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%2... > for an example failure. Considering the builder was down for a good part of the day, it's not obvious what's failing. Will take a look though.
Message was sent while issue was closed.
Note to self: See also https://code.google.com/p/chromium/issues/detail?id=396333 |