Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 897163002: Always use the 64 bit linker on Linux 32 bit builds. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang, Nico, dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always use the 64 bit linker on Linux 32 bit builds. Recent changes (merging PDFium) have pushed some binaries over the limit. BUG=453844 R=thestig@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/4e86d25e8bee33105970ed9b1b4eb0684fa955ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M build/common.gypi View 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
jam
5 years, 10 months ago (2015-02-05 01:11:06 UTC) #2
Lei Zhang
- Can you prepend "Linux: " to the commit message? - The bug number doesn't ...
5 years, 10 months ago (2015-02-05 01:42:40 UTC) #3
jam
On 2015/02/05 01:42:40, Lei Zhang wrote: > - Can you prepend "Linux: " to the ...
5 years, 10 months ago (2015-02-05 01:50:24 UTC) #4
Lei Zhang
On 2015/02/05 01:50:24, jam wrote: > On 2015/02/05 01:42:40, Lei Zhang wrote: > > - ...
5 years, 10 months ago (2015-02-05 01:54:43 UTC) #5
jam
On 2015/02/05 01:54:43, Lei Zhang wrote: > On 2015/02/05 01:50:24, jam wrote: > > On ...
5 years, 10 months ago (2015-02-05 02:14:44 UTC) #6
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-05 03:05:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/897163002/1
5 years, 10 months ago (2015-02-05 03:06:24 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4e86d25e8bee33105970ed9b1b4eb0684fa955ed Cr-Commit-Position: refs/heads/master@{#314730}
5 years, 10 months ago (2015-02-05 03:11:53 UTC) #10
jam
Committed patchset #1 (id:1) manually as 4e86d25e8bee33105970ed9b1b4eb0684fa955ed (presubmit successful).
5 years, 10 months ago (2015-02-05 03:12:03 UTC) #11
Nico
fyi, I tried the same change (except I did it for gn too) in https://code.google.com/p/chromium/issues/detail?id=396333 ...
5 years, 10 months ago (2015-02-05 03:30:15 UTC) #13
dcheng
Is there any chance this is causing errors like: Command: ../out/Debug/browser_tests --test-launcher-bot-mode --test-launcher-summary-output=/tmp/isolated_out2lpJpD/output.json ../out/Debug/browser_tests: error ...
5 years, 10 months ago (2015-02-05 08:17:56 UTC) #15
Lei Zhang
On 2015/02/05 08:17:56, dcheng wrote: > Is there any chance this is causing errors like: ...
5 years, 10 months ago (2015-02-05 08:24:08 UTC) #16
Nico
5 years, 3 months ago (2015-09-11 20:18:31 UTC) #17
Message was sent while issue was closed.
Note to self: See also
https://code.google.com/p/chromium/issues/detail?id=396333

Powered by Google App Engine
This is Rietveld 408576698