Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1337993002: Revert of Optimize for TouchStart responsiveness (Closed)

Created:
5 years, 3 months ago by jam
Modified:
5 years, 3 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Optimize for TouchStart responsiveness (patchset #22 id:410001 of https://codereview.chromium.org/1320633002/ ) Reason for revert: adds flaky test, causes other test to be flaky BUG=530250 Original issue's description: > Optimize for TouchStart responsiveness by modeling what the user is doing. > We have come to realize that TouchStart responsiveness is really critical > for a good user experience. > > This patch introduces a (initially very simple) system for modeling > what the user is doing and predicting when they are likely to initiate a > new gesture (taps are ignored). We order task priority accordingly. > > In addition we extend the estimation of task cost to loading tasks > which are often a significant source of jank. > > Load tasks can be very long (easily up to 1000ms). There is > no good way to cooperatively schedule such a task but the > least worst user experience seems to be if we get them out > of the way as fast as possible. Ideally we'd prioritize them > but the order of IPC and LoadingTasks currently needs to > be more or less in lockstep. Instead we deprioritize compositor > tasks inside a compositor gesture, which has the effect of > prioritizing other work. > > Expected changes on Perf bots: > 1. first_gesture_scroll_update_latency in smoothness.scrolling_tough_ad_cases > should go down. This should be highly user visible. > 2. It's possible some compositor metrics such as queueing_durations > may regress. I don't expect this to be user visible. > > BUG=510398 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/464b1a5144ddb5135dad845aceb5b1f074221387 > Cr-Commit-Position: refs/heads/master@{#347937} TBR=jochen@chromium.org,skyostil@chromium.org,alexclarke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510398 Committed: https://crrev.com/cb6de992880a9dfa6fe6efa00a096956f86a2ed9 Cr-Commit-Position: refs/heads/master@{#348440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+452 lines, -1268 lines) Patch
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/scheduler/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/scheduler/renderer/renderer_scheduler.h View 2 chunks +0 lines, -15 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.h View 7 chunks +54 lines, -61 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.cc View 21 chunks +260 lines, -328 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl_unittest.cc View 33 chunks +136 lines, -322 lines 0 comments Download
M components/scheduler/renderer/task_cost_estimator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/scheduler/renderer/task_cost_estimator.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/scheduler/renderer/task_cost_estimator_unittest.cc View 2 chunks +2 lines, -15 lines 0 comments Download
D components/scheduler/renderer/user_model.h View 1 chunk +0 lines, -69 lines 0 comments Download
D components/scheduler/renderer/user_model.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D components/scheduler/renderer/user_model_unittest.cc View 1 chunk +0 lines, -298 lines 0 comments Download
M components/scheduler/scheduler.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
Created Revert of Optimize for TouchStart responsiveness
5 years, 3 months ago (2015-09-11 18:25:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337993002/1
5 years, 3 months ago (2015-09-11 18:25:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 18:27:10 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cb6de992880a9dfa6fe6efa00a096956f86a2ed9 Cr-Commit-Position: refs/heads/master@{#348440}
5 years, 3 months ago (2015-09-11 18:27:55 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:24:21 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb6de992880a9dfa6fe6efa00a096956f86a2ed9
Cr-Commit-Position: refs/heads/master@{#348440}

Powered by Google App Engine
This is Rietveld 408576698