Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Unified Diff: util/win/exception_handler_server.cc

Issue 1337953003: win: Fix pipe leak on connection (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: pcheck createthread Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | util/win/registration_protocol_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/exception_handler_server.cc
diff --git a/util/win/exception_handler_server.cc b/util/win/exception_handler_server.cc
index 2d702f20d0627a18a54597197b77c3920b015279..50a5fa3c509021cb4fe28eb6bf875e34bd243e83 100644
--- a/util/win/exception_handler_server.cc
+++ b/util/win/exception_handler_server.cc
@@ -211,6 +211,7 @@ void ExceptionHandlerServer::Run(Delegate* delegate,
512,
0,
nullptr);
+ PCHECK(pipe != INVALID_HANDLE_VALUE) << "CreateNamedPipe";
// Ownership of this object (and the pipe instance) is given to the new
// thread. We close the thread handles at the end of the scope. They clean
@@ -224,6 +225,7 @@ void ExceptionHandlerServer::Run(Delegate* delegate,
shutdown_token);
thread_handles[i].reset(
CreateThread(nullptr, 0, &PipeServiceProc, context, 0, nullptr));
+ PCHECK(thread_handles[i].is_valid()) << "CreateThread";
}
delegate->ExceptionHandlerServerStarted();
« no previous file with comments | « no previous file | util/win/registration_protocol_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698