Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1337883002: [builtins] Remove the weird STACK_OVERFLOW builtin. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Remove the weird STACK_OVERFLOW builtin. Just use a %ThrowStackOverflow runtime function instead, which does the trick, especially since the Isolate already has a preallocated StackOverflow error for that. R=mstarzinger@chromium.org Committed: https://crrev.com/39604dda567b9ba9f4dcfe42f95471f30ec7cb6b Cr-Commit-Position: refs/heads/master@{#30693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -31 lines) Patch
M src/arm/builtins-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips/builtins-mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime.js View 2 chunks +0 lines, -6 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 3 months ago (2015-09-11 09:49:07 UTC) #1
Benedikt Meurer
Hey Michi, Next weird builtin gone. Please take a look. Thanks, Benedikt
5 years, 3 months ago (2015-09-11 09:50:07 UTC) #2
Michael Starzinger
LGTM.
5 years, 3 months ago (2015-09-11 09:54:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337883002/1
5 years, 3 months ago (2015-09-11 10:20:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 10:21:33 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-11 10:21:47 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/39604dda567b9ba9f4dcfe42f95471f30ec7cb6b
Cr-Commit-Position: refs/heads/master@{#30693}

Powered by Google App Engine
This is Rietveld 408576698