src/full-codegen/ia32/full-codegen-ia32.cc - Issue 1337883002: [builtins] Remove the weird STACK_OVERFLOW builtin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 1337883002: [builtins] Remove the weird STACK_OVERFLOW builtin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index 42c12b3773fb90b5b53b03b0908bec3f7f9aaa0f..a35a35819cdd25c10a36d6e7777ff465f62bbd3e 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -150,7 +150,7 @@ void FullCodeGenerator::Generate() {

ExternalReference::address_of_real_stack_limit(isolate());

__ cmp(ecx, Operand::StaticVariable(stack_limit));

__ j(above_equal, &ok, Label::kNear);

- __ InvokeBuiltin(Context::STACK_OVERFLOW_BUILTIN_INDEX, CALL_FUNCTION);

+ __ CallRuntime(Runtime::kThrowStackOverflow, 0);

__ bind(&ok);

}

__ mov(eax, Immediate(isolate()->factory()->undefined_value()));