src/full-codegen/mips/full-codegen-mips.cc - Issue 1337883002: [builtins] Remove the weird STACK_OVERFLOW builtin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 1337883002: [builtins] Remove the weird STACK_OVERFLOW builtin. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/mips/full-codegen-mips.cc

diff --git a/src/full-codegen/mips/full-codegen-mips.cc b/src/full-codegen/mips/full-codegen-mips.cc

index 35747a6087be9657c3e94e7a6759798c99d69198..791a8b2011940d18c71f0e745ef6ca6016469af1 100644

--- a/src/full-codegen/mips/full-codegen-mips.cc

+++ b/src/full-codegen/mips/full-codegen-mips.cc

@@ -162,7 +162,7 @@ void FullCodeGenerator::Generate() {

__ Subu(t5, sp, Operand(locals_count * kPointerSize));

__ LoadRoot(a2, Heap::kRealStackLimitRootIndex);

__ Branch(&ok, hs, t5, Operand(a2));

- __ InvokeBuiltin(Context::STACK_OVERFLOW_BUILTIN_INDEX, CALL_FUNCTION);

+ __ CallRuntime(Runtime::kThrowStackOverflow, 0);

__ bind(&ok);

}

__ LoadRoot(t5, Heap::kUndefinedValueRootIndex);