chrome/browser/resources/omnibox_result.html - Issue 13375003: Fixing iframe jank in the local omnibox popup.

Unified Diff: chrome/browser/resources/omnibox_result.html

Issue 13375003: Fixing iframe jank in the local omnibox popup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressing cc comments. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js ('K') | « chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js ('k') | chrome/browser/resources/omnibox_result.js » ('j') | chrome/browser/resources/omnibox_result.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/omnibox_result.html

diff --git a/chrome/browser/resources/omnibox_result.html b/chrome/browser/resources/omnibox_result.html

new file mode 100644

index 0000000000000000000000000000000000000000..004d77cda632a44baf144ca7f0bf9b0a69d57fdd

--- /dev/null

+++ b/chrome/browser/resources/omnibox_result.html

@@ -0,0 +1,28 @@

+<!DOCTYPE html>

+<html>

+<head>

+<script src="chrome-search://suggestion/result.js"></script>

+<style>

+body {

+ -webkit-user-select: none;

+ cursor: default;

Dan Beam 2013/04/05 01:07:37 ^ er, this should be the default... no?

Jered 2013/04/05 15:30:23 This is here to avoid showing an I beam cursor ove

+ margin: 0;

+ overflow: hidden;

+ position: fixed;

+ width: 100%;

Dan Beam 2013/04/05 01:07:37 \n

Jered 2013/04/05 15:30:23 Done.

+body > div {

+ overflow: hidden;

+ text-overflow: ellipsis;

+ white-space: nowrap;

Dan Beam 2013/04/05 01:07:37 \n

Jered 2013/04/05 15:30:23 Done.

+.hide { display: none; }

Dan Beam 2013/04/05 01:07:37 why are you not using [hidden] instead? if this s

Jered 2013/04/05 15:30:23 Sorry, what do you mean by [hidden]? visibility:hi

Dan Beam 2013/04/05 22:19:54 someEl.hidden = true; // in JS

Jered 2013/04/05 23:43:41 Done.

+</style>

+</head>

+<body>

+ <div>

+ <span id="contents"></span>

+ <span id="optional"> – <span id="title"></span></span>

+ </div>

+</body>

+</html>