Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Unified Diff: chrome/browser/resources/omnibox_result.js

Issue 13375003: Fixing iframe jank in the local omnibox popup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing cc comments. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/omnibox_result.js
diff --git a/chrome/browser/resources/omnibox_result.js b/chrome/browser/resources/omnibox_result.js
new file mode 100644
index 0000000000000000000000000000000000000000..cff0f2bf7a1d32d5367ff8c643a40a9fe98b78a6
--- /dev/null
+++ b/chrome/browser/resources/omnibox_result.js
@@ -0,0 +1,20 @@
+/**
Dan Beam 2013/04/05 01:07:37 does this need a copyright?
Jered 2013/04/05 15:30:23 Done.
+ * @fileoverview Click handler for omnibox results.
+ */
+
+/**
+ * The origin of the embedding page.
+ * Must be in double quotes for proper escaping.
Dan Beam 2013/04/05 01:07:37 what must be in double quotes? please clarify
Jered 2013/04/05 15:30:23 Done.
+ * @type {string}
+ * @const
+ */
+var EMBEDDER_ORIGIN = "%s";
+
+function handleClick(event) {
+ var clickMessage = {'click': event.button};
+ top.postMessage(clickMessage, EMBEDDER_ORIGIN);
Dan Beam 2013/04/05 01:07:37 top.postMessage({click: event.button}, EMBEDDER_OR
Jered 2013/04/05 15:30:23 Done.
+}
+
+document.addEventListener('DOMContentLoaded', function() {
Dan Beam 2013/04/05 01:07:37 why do you need to wait until DOMContentLoaded?
Jered 2013/04/05 15:30:23 I don't. Done.
+ window.addEventListener('click', handleClick, false);
+});
Dan Beam 2013/04/05 01:07:37 why is this all in the global namespace?
Jered 2013/04/05 15:30:23 Where would be better? (This script will be the on

Powered by Google App Engine
This is Rietveld 408576698