chrome/browser/resources/omnibox_result.html - Issue 13375003: Fixing iframe jank in the local omnibox popup.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/omnibox_result.html

Issue 13375003: Fixing iframe jank in the local omnibox popup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressing cc comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js ('K') | « chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js ('k') | chrome/browser/resources/omnibox_result.js » ('j') | chrome/browser/resources/omnibox_result.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="chrome-search://suggestion/result.js"></script>

	5 <style>

	6 body {

	7 -webkit-user-select: none;

	8 cursor: default;
	Dan Beam 2013/04/05 01:07:37 ^ er, this should be the default... no? ^ er, this should be the default... no? Jered 2013/04/05 15:30:23 This is here to avoid showing an I beam cursor ove Show quoted text On 2013/04/05 01:07:37, Dan Beam wrote: > ^ er, this should be the default... no? This is here to avoid showing an I beam cursor over text inside the frame.
	9 margin: 0;

	10 overflow: hidden;

	11 position: fixed;

	12 width: 100%;

	13 }
	Dan Beam 2013/04/05 01:07:37 \n \n Jered 2013/04/05 15:30:23 Done. Show quoted text On 2013/04/05 01:07:37, Dan Beam wrote: > \n Done.
	14 body > div {

	15 overflow: hidden;

	16 text-overflow: ellipsis;

	17 white-space: nowrap;

	18 }
	Dan Beam 2013/04/05 01:07:37 \n \n Jered 2013/04/05 15:30:23 Done. Show quoted text On 2013/04/05 01:07:37, Dan Beam wrote: > \n Done.
	19 .hide { display: none; }
	Dan Beam 2013/04/05 01:07:37 why are you not using [hidden] instead? if this s why are you not using [hidden] instead? if this stays .hide { display: none; } Jered 2013/04/05 15:30:23 Sorry, what do you mean by [hidden]? visibility:hi Show quoted text On 2013/04/05 01:07:37, Dan Beam wrote: > why are you not using [hidden] instead? if this stays > > .hide { > display: none; > } Sorry, what do you mean by [hidden]? visibility:hidden or an attribute selector? I've reformatted this though. Dan Beam 2013/04/05 22:19:54 someEl.hidden = true; // in JS Show quoted text On 2013/04/05 15:30:23, Jered wrote: > On 2013/04/05 01:07:37, Dan Beam wrote: > > why are you not using [hidden] instead? if this stays > > > > .hide { > > display: none; > > } > > Sorry, what do you mean by [hidden]? visibility:hidden or an attribute selector? > I've reformatted this though. someEl.hidden = true; // in JS Jered 2013/04/05 23:43:41 Done. Show quoted text On 2013/04/05 22:19:54, Dan Beam wrote: > On 2013/04/05 15:30:23, Jered wrote: > > On 2013/04/05 01:07:37, Dan Beam wrote: > > > why are you not using [hidden] instead? if this stays > > > > > > .hide { > > > display: none; > > > } > > > > Sorry, what do you mean by [hidden]? visibility:hidden or an attribute > selector? > > I've reformatted this though. > > someEl.hidden = true; // in JS Done.
	20 </style>

	21 </head>

	22 <body>

	23 <div>

	24 <span id="contents"></span>

	25 <span id="optional"> – <span id="title"></span></span>

	26 </div>

	27 </body>

	28 </html>

OLD	NEW