Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1337113007: Stop unfreezing tabs "frozen" for lazy loads (Closed)

Created:
5 years, 3 months ago by gone
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop unfreezing tabs "frozen" for lazy loads When opening a tab in the background on Svelte devices, tabs are marked as "frozen" without actually being frozen (no saved state). * Make CompositorViewHolder load these tabs properly instead of trying to unfreeze them. * Make Tab#unfreezeContents() protected so that nothing can handle this. * Clear out pointers when destroying the objects and clean up destruction, in general. * Stop destroying some TabObservers twice. * Add a test to catch this. * Moves process killing to the end of destroy() instead of the middle. BUG=495877 Committed: https://crrev.com/f2c7f2a4c2332d104467eaf71651cfb6b3a18a13 Cr-Commit-Position: refs/heads/master@{#348755}

Patch Set 1 #

Messages

Total messages: 8 (2 generated)
gone
5 years, 3 months ago (2015-09-14 21:56:22 UTC) #2
Maria
lgtm
5 years, 3 months ago (2015-09-14 23:02:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1337113007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1337113007/1
5 years, 3 months ago (2015-09-14 23:04:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 23:12:16 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f2c7f2a4c2332d104467eaf71651cfb6b3a18a13 Cr-Commit-Position: refs/heads/master@{#348755}
5 years, 3 months ago (2015-09-14 23:13:35 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:38:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2c7f2a4c2332d104467eaf71651cfb6b3a18a13
Cr-Commit-Position: refs/heads/master@{#348755}

Powered by Google App Engine
This is Rietveld 408576698