chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java - Issue 1337113007: Stop unfreezing tabs "frozen" for lazy loads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java

Issue 1337113007: Stop unfreezing tabs "frozen" for lazy loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java

index 023766a92e727f92fc90e280cfd344d6291db7a8..f6d5f412d77c7a53395844417a1eb7156d3316bd 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java

@@ -398,7 +398,7 @@ public abstract class TabModelBase extends TabModelJniBridge {

return currentTab != null ? currentTab.getId() : Tab.INVALID_TAB_ID;

}

- private boolean hasVaildTab() {

+ private boolean hasValidTab() {

if (mTabs.size() <= 0) return false;

for (int i = 0; i < mTabs.size(); i++) {

if (!mTabs.get(i).isClosing()) return true;

@@ -417,7 +417,7 @@ public abstract class TabModelBase extends TabModelJniBridge {

mModelDelegate.selectModel(isIncognito());

}

- if (!hasVaildTab()) {

+ if (!hasValidTab()) {

mIndex = INVALID_TAB_INDEX;

} else {

mIndex = MathUtils.clamp(i, 0, mTabs.size() - 1);