Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1689)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 1337113007: Stop unfreezing tabs "frozen" for lazy loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index 67f0e5b6558ee4a6b681fb92be9ff94a7f705b05..cea05122925a8616eaffd40f2de796b10c40a44b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -2022,10 +2022,11 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
}
/**
- * Restores the WebContents from its saved state.
+ * Restores the WebContents from its saved state. This should only be called if the tab is
+ * frozen with a saved TabState, and NOT if it was frozen for a lazy load.
* @return Whether or not the restoration was successful.
*/
- public boolean unfreezeContents() {
+ protected boolean unfreezeContents() {
try {
TraceEvent.begin("Tab.unfreezeContents");
assert mFrozenContentsState != null;
@@ -2376,7 +2377,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
/**
* @return Parameters that should be used for a lazily loaded Tab. May be null.
*/
- protected LoadUrlParams getPendingLoadParams() {
+ private LoadUrlParams getPendingLoadParams() {
return mPendingLoadParams;
}

Powered by Google App Engine
This is Rietveld 408576698