Blink MediaRecorder: adding "creation" LayoutTest and reconnecting "canRecordMimeType"

Blink MediaRecorder: adding "creation" LayoutTest and reconnecting "canRecordMimeType"

This CL:
- reconnects canRecordMimeType LayoutTest
- adds a new -creation test
- _does not_ reconnect basic-video test because the
underlying Cr test infra does not provide meaningful
video tracks, hitting a DCHECK in VideoTrackRecorder
(I need to work on that).
- changes a ASSERT_NOTREACHED() in MediaRecorder
with a WTF_LOG() to allow debugging.
- Allows writeData() to be called when MediaRecorder 
is not in Recording state if |lastInSlice| is true.

BUG=262211
Committed: https://crrev.com/481a95475284a48c7ee346991499faf73636dd68
git-svn-id: svn://svn.chromium.org/blink/trunk@202376 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[mcasas, 2015-09-15 01:03:08]

mcasas@chromium.org changed reviewers:
+ peter@chromium.org

[mcasas, 2015-09-15 01:03:08]

peter@ PTAL

[Peter Beverloo, 2015-09-16 15:09:01]

lgtm

https://codereview.chromium.org/1336943004/diff/1/LayoutTests/fast/mediarecor...
File LayoutTests/fast/mediarecorder/MediaRecorder-canRecordMimeType-expected.txt
(right):

https://codereview.chromium.org/1336943004/diff/1/LayoutTests/fast/mediarecor...
LayoutTests/fast/mediarecorder/MediaRecorder-canRecordMimeType-expected.txt:3:
PASS check MediaRecorder.canRecordMimeType() with video/vp8
Where does the space come from?

https://codereview.chromium.org/1336943004/diff/1/LayoutTests/fast/mediarecor...
File LayoutTests/fast/mediarecorder/MediaRecorder-creation.html (right):

https://codereview.chromium.org/1336943004/diff/1/LayoutTests/fast/mediarecor...
LayoutTests/fast/mediarecorder/MediaRecorder-creation.html:8: // Note that
recording is _not_ started, for that we would need Mock sources.
Is there a bug you could refer to, to clarify that this is still a
work-in-progress?

https://codereview.chromium.org/1336943004/diff/1/LayoutTests/fast/mediarecor...
LayoutTests/fast/mediarecorder/MediaRecorder-creation.html:13: gotStream =
test.step_func(function(stream) {
use "var gotStream" to not place these variables on the global scope?

https://codereview.chromium.org/1336943004/diff/1/Source/modules/mediarecorde...
File Source/modules/mediarecorder/MediaRecorder.cpp (right):

https://codereview.chromium.org/1336943004/diff/1/Source/modules/mediarecorde...
Source/modules/mediarecorder/MediaRecorder.cpp:251: WTF_LOG(Media,
"createBlobEvent() not implemented.");
You could use notImplemented() from Source/platform/NotImplemented.h here.

[mcasas, 2015-09-16 16:08:57]

Patchset #2 (id:20001) has been deleted

[mcasas, 2015-09-16 18:03:22]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2015-09-16 18:03:23]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1336943004/#ps40001
(title: "peter's comments")

[commit-bot: I haz the power, 2015-09-16 18:03:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1336943004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1336943004/40001

[mcasas, 2015-09-16 18:04:15]

https://codereview.chromium.org/1336943004/diff/1/LayoutTests/fast/mediarecor...
File LayoutTests/fast/mediarecorder/MediaRecorder-canRecordMimeType-expected.txt
(right):

https://codereview.chromium.org/1336943004/diff/1/LayoutTests/fast/mediarecor...
LayoutTests/fast/mediarecorder/MediaRecorder-canRecordMimeType-expected.txt:3:
PASS check MediaRecorder.canRecordMimeType() with video/vp8
On 2015/09/16 15:09:01, Peter Beverloo wrote:
> Where does the space come from?

PASS ones have a blank at the end, whereas  FAILs don't. 
I guess is part of the JS test infra.

https://codereview.chromium.org/1336943004/diff/1/LayoutTests/fast/mediarecor...
File LayoutTests/fast/mediarecorder/MediaRecorder-creation.html (right):

https://codereview.chromium.org/1336943004/diff/1/LayoutTests/fast/mediarecor...
LayoutTests/fast/mediarecorder/MediaRecorder-creation.html:8: // Note that
recording is _not_ started, for that we would need Mock sources.
On 2015/09/16 15:09:01, Peter Beverloo wrote:
> Is there a bug you could refer to, to clarify that this is still a
> work-in-progress?

Hmm the wording was unfortunate. The point I wanted to make
here is that the MediaRecorder-basic-video.html did hit a DCHECK
in Chrome's VideoTrackRecorder ctor [1] because the Blink Video
Track has no Cr counterpart and is empty. 

To workaround that I added this test that checks that a 
MediaRecorder can be created from a MediaSource.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...

https://codereview.chromium.org/1336943004/diff/1/LayoutTests/fast/mediarecor...
LayoutTests/fast/mediarecorder/MediaRecorder-creation.html:13: gotStream =
test.step_func(function(stream) {
On 2015/09/16 15:09:01, Peter Beverloo wrote:
> use "var gotStream" to not place these variables on the global scope?

Done.

https://codereview.chromium.org/1336943004/diff/1/Source/modules/mediarecorde...
File Source/modules/mediarecorder/MediaRecorder.cpp (right):

https://codereview.chromium.org/1336943004/diff/1/Source/modules/mediarecorde...
Source/modules/mediarecorder/MediaRecorder.cpp:251: WTF_LOG(Media,
"createBlobEvent() not implemented.");
On 2015/09/16 15:09:01, Peter Beverloo wrote:
> You could use notImplemented() from Source/platform/NotImplemented.h here.

Done, thanks!

[commit-bot: I haz the power, 2015-09-16 19:24:20]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202376

[commit-bot: I haz the power, 2015-09-23 12:59:12]

Patchset 2 (id:??) landed as
https://crrev.com/481a95475284a48c7ee346991499faf73636dd68