Blink MediaRecorder: adding "creation" LayoutTest and reconnecting "canRecordMimeType"

Source/modules/mediarecorder/MediaRecorder.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/mediarecorder/MediaRecorder.h"
 
 #include "core/dom/DOMError.h"
 #include "core/fileapi/Blob.h"
 #include "modules/EventModules.h"
 #include "modules/EventTargetModules.h"
 #include "modules/mediarecorder/MediaRecorderErrorEvent.h"
+#include "platform/Logging.h"
 #include "platform/blob/BlobData.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebMediaStream.h"
 
 namespace blink {
 
 namespace {
 
 String stateToString(MediaRecorder::State state)
 {
@@ skipping 174 matching lines @@
 
     m_stopped = true;
     m_stream.clear();
     m_recorderHandler.clear();
 
     scheduleDispatchEvent(Event::create(EventTypeNames::stop));
 }
 
 void MediaRecorder::writeData(const char* data, size_t length, bool lastInSlice)
 {
-    ASSERT(m_state == State::Recording);
-
-    if (m_stopped) {
+    if (!lastInSlice && m_stopped) {
         m_stopped = false;
         scheduleDispatchEvent(Event::create(EventTypeNames::start));
     }
 
     // TODO(mcasas): Act as |m_ignoredMutedMedia| instructs if |m_stream| track(s) is in muted() state.
     // TODO(mcasas): Use |lastInSlice| to indicate to JS that recording is done.
 
     OwnPtr<BlobData> blobData = BlobData::create();
     blobData->appendBytes(data, length);
     createBlobEvent(blobData.release());
@@ skipping 22 matching lines @@
     scheduleDispatchEvent(MediaRecorderErrorEvent::create(
         EventTypeNames::error, false, false, "OtherRecordingError", message));
 
     if (m_state == State::Recording)
         stopRecording();
 }
 
 void MediaRecorder::createBlobEvent(PassOwnPtr<BlobData> blobData)
 {
     // TODO(mcasas): Launch a BlobEvent when that class is landed, but also see https://github.com/w3c/mediacapture-record/issues/17.
-    ASSERT_NOT_REACHED();
+    WTF_LOG(Media, "createBlobEvent() not implemented.");

[Peter Beverloo, 2015/09/16 15:09:01]

You could use notImplemented() from Source/platform/NotImplemented.h here.

[mcasas, 2015/09/16 18:04:15]

Done, thanks!

 }
 
 void MediaRecorder::stopRecording()
 {
     ASSERT(m_state != State::Inactive);
     m_state = State::Inactive;
 
     m_recorderHandler->stop();
 
     createBlobEvent(BlobData::create());
@@ skipping 19 matching lines @@
 
 DEFINE_TRACE(MediaRecorder)
 {
     visitor->trace(m_stream);
     visitor->trace(m_scheduledEvents);
     RefCountedGarbageCollectedEventTargetWithInlineData<MediaRecorder>::trace(visitor);
     ActiveDOMObject::trace(visitor);
 }
 
 } // namespace blink