Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Unified Diff: Source/modules/mediarecorder/MediaRecorder.cpp

Issue 1336943004: Blink MediaRecorder: adding "creation" LayoutTest and reconnecting "canRecordMimeType" (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: peter's comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/mediarecorder/MediaRecorder-creation.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/mediarecorder/MediaRecorder.cpp
diff --git a/Source/modules/mediarecorder/MediaRecorder.cpp b/Source/modules/mediarecorder/MediaRecorder.cpp
index 7294c82e74d4b4e9dc8c7e0c627299fa0b094176..3183ca6005282f21e176fabf76c8c5c3bf8d7d43 100644
--- a/Source/modules/mediarecorder/MediaRecorder.cpp
+++ b/Source/modules/mediarecorder/MediaRecorder.cpp
@@ -10,6 +10,7 @@
#include "modules/EventModules.h"
#include "modules/EventTargetModules.h"
#include "modules/mediarecorder/MediaRecorderErrorEvent.h"
+#include "platform/NotImplemented.h"
#include "platform/blob/BlobData.h"
#include "public/platform/Platform.h"
#include "public/platform/WebMediaStream.h"
@@ -204,9 +205,7 @@ void MediaRecorder::stop()
void MediaRecorder::writeData(const char* data, size_t length, bool lastInSlice)
{
- ASSERT(m_state == State::Recording);
-
- if (m_stopped) {
+ if (!lastInSlice && m_stopped) {
m_stopped = false;
scheduleDispatchEvent(Event::create(EventTypeNames::start));
}
@@ -249,7 +248,7 @@ void MediaRecorder::failOtherRecordingError(const WebString& message)
void MediaRecorder::createBlobEvent(PassOwnPtr<BlobData> blobData)
{
// TODO(mcasas): Launch a BlobEvent when that class is landed, but also see https://github.com/w3c/mediacapture-record/issues/17.
- ASSERT_NOT_REACHED();
+ notImplemented();
}
void MediaRecorder::stopRecording()
« no previous file with comments | « LayoutTests/fast/mediarecorder/MediaRecorder-creation.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698