Issue 133683002: Retry "Templatise type representation" after making clang happy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133683002: Retry "Templatise type representation" after making clang happy (Closed)

Created:
6 years, 11 months ago by rossberg

Modified:
6 years, 11 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Retry "Templatise type representation" after making clang happy The only thing different now is line types.h:208/236, which had a static_cast<Type*> before. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18533

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+638 lines, -557 lines)			Patch
M	src/ast.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ast.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/code-stubs.cc	View	2 chunks	+10 lines, -11 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/hydrogen.cc	View	8 chunks	+12 lines, -14 lines	0 comments	Download
M	src/ic.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ic.cc	View	7 chunks	+30 lines, -38 lines	0 comments	Download
M	src/list.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/objects.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/objects.cc	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	src/property-details.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/stub-cache.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/type-info.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/types.h	View	5 chunks	+173 lines, -105 lines	0 comments	Download
M	src/types.cc	View	16 chunks	+216 lines, -183 lines	0 comments	Download
M	src/typing.cc	View	13 chunks	+33 lines, -34 lines	0 comments	Download
M	test/cctest/test-types.cc	View	27 chunks	+138 lines, -149 lines	0 comments	Download

Total messages: 3 (0 generated)

rossberg

6 years, 11 months ago (2014-01-10 12:19:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18533 (presubmit successful).